From: bot+bpf-ci@kernel.org
To: xukuohai@huaweicloud.com,bpf@vger.kernel.org,linux-kernel@vger.kernel.org
Cc: ast@kernel.org,daniel@iogearbox.net,andrii@kernel.org,eddyz87@gmail.com,memxor@gmail.com,yonghong.song@linux.dev,jolsa@kernel.org,kpsingh@kernel.org,a.s.protopopov@gmail.com,ameryhung@gmail.com,eyal.birger@gmail.com,rongtao@cestc.cn,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,clm@meta.com,ihor.solodrai@linux.dev
Subject: Re: [RFC PATCH bpf-next 06/12] bpf: Add type check for SDT probe site
Date: Sat, 27 Jun 2026 15:22:45 +0000 (UTC) [thread overview]
Message-ID: <13795f227ac0dcb75bde245ffd80da37bb0f4d9f8eaf5184b05e5c41fbf29d18@mail.kernel.org> (raw)
In-Reply-To: <d20d2be69ab6bfa5f81c249bf54c2d47558d239e.1782571533.git.xukuohai@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]
> bpf: Add type check for SDT probe site
>
> The NOP instruction at SDT probe site will be patched to a call
> instruction to observer programs. To ensure the arguments passed
> to observers are as expected, add type check for bpf SDT probe site.
>
> The check for probes with no arguments always succeeds.
>
> For probes with arguments, argument registers are checked against
> the types declared by FUNC_PROTO for the probe site.
>
> Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
This looks like a bug fix for SDT probe support. The commit adds type
checking and protection for SDT probe sites to prevent them from being
incorrectly optimized away by bpf_opt_remove_nops() and to ensure their
argument registers remain live during liveness analysis. These issues
were introduced when SDT probe support was added. Should this include:
Fixes: b96ff657266c ("bpf: Create insn_array map for bpf SDT probe")
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/28292842584
next prev parent reply other threads:[~2026-06-27 15:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 22:51 [RFC PATCH bpf-next 00/12] bpf: Introduce static-defined tracing probe for BPF Xu Kuohai
2026-06-27 20:51 ` [syzbot ci] " syzbot ci
2026-06-27 22:51 ` [RFC PATCH bpf-next 01/12] libbpf: Prepare bpf SDT probe section for the linker Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 02/12] libbpf: Introduce bpf SDT probe macros Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 03/12] libbpf: Add bpf_sdt_notes section parser Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 04/12] bpf: Create insn_array map for bpf SDT probe Xu Kuohai
2026-06-27 15:34 ` bot+bpf-ci
2026-06-27 22:51 ` [RFC PATCH bpf-next 05/12] bpf: Collect SDT probe BTF IDs from BTF decl tags Xu Kuohai
2026-06-27 15:34 ` bot+bpf-ci
2026-06-27 22:51 ` [RFC PATCH bpf-next 06/12] bpf: Add type check for SDT probe site Xu Kuohai
2026-06-27 15:22 ` bot+bpf-ci [this message]
2026-06-27 22:51 ` [RFC PATCH bpf-next 07/12] bpf: Record probe name in SDT map Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 08/12] libbpf: Add libbpf support to load SDT observer program Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 09/12] bpf: Add kernel " Xu Kuohai
2026-06-27 15:22 ` bot+bpf-ci
2026-06-27 22:51 ` [RFC PATCH bpf-next 10/12] bpf: Support attach and detach for " Xu Kuohai
2026-06-27 22:51 ` [RFC PATCH bpf-next 11/12] bpf, x86: Add JIT support SDT for probe Xu Kuohai
2026-06-27 15:22 ` bot+bpf-ci
2026-06-27 22:51 ` [RFC PATCH bpf-next 12/12] selftests/bpf: Add tests for bpf SDT probe Xu Kuohai
2026-06-29 2:14 ` [RFC PATCH bpf-next 00/12] bpf: Introduce static-defined tracing probe for BPF Leon Hwang
2026-06-29 3:27 ` Xu Kuohai
2026-06-29 5:26 ` Leon Hwang
2026-06-29 7:51 ` Xu Kuohai
2026-06-29 10:55 ` Leon Hwang
2026-06-29 11:32 ` Xu Kuohai
2026-06-29 13:53 ` Leon Hwang
2026-06-30 1:19 ` Xu Kuohai
2026-06-30 2:14 ` Leon Hwang
2026-06-30 2:29 ` Xu Kuohai
2026-06-30 22:07 ` Alexei Starovoitov
2026-07-01 2:18 ` Xu Kuohai
2026-07-01 4:17 ` Anton Protopopov
2026-07-01 6:11 ` Xu Kuohai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13795f227ac0dcb75bde245ffd80da37bb0f4d9f8eaf5184b05e5c41fbf29d18@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=a.s.protopopov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=rongtao@cestc.cn \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®