From: Joe Perches <joe@perches.com>
To: paulmck@linux.vnet.ibm.com
Cc: apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: False positive in checkpatch
Date: Mon, 23 Sep 2013 21:21:07 -0700 [thread overview]
Message-ID: <1379996467.3575.67.camel@joe-AO722> (raw)
In-Reply-To: <20130923225949.GA26278@linux.vnet.ibm.com>
On Mon, 2013-09-23 at 15:59 -0700, Paul E. McKenney wrote:
> Hello!
>
> The checkpatch.pl script complains as follows:
>
> ERROR: need consistent spacing around '*' (ctx:WxB)
> #57: FILE: include/linux/rcupdate.h:564:
> + ACCESS_ONCE(p) = (typeof(*(v)) __force space *)(v); \
>
> Of course, the two uses of '*' are doing different things, so it should
> be OK for the spacing to be different.
>
> Could you please fix this?
>
> Thanx, Paul
>
Hi Paul.
Try this patch: https://lkml.org/lkml/2013/9/2/428
Andy? Can you verify this suggested patch please?
next prev parent reply other threads:[~2013-09-24 4:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 22:59 Paul E. McKenney
2013-09-24 4:21 ` Joe Perches [this message]
2013-09-24 14:03 ` Paul E. McKenney
2013-09-24 15:13 ` Andy Whitcroft
2013-09-24 15:45 ` Paul E. McKenney
2013-09-24 14:24 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379996467.3575.67.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®