mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH] can: dev: alloc_candev_mqs(): add missing default CAN capabilitied
Date: Fri, 16 Jan 2026 15:45:31 +0100	[thread overview]
Message-ID: <137dcd58-32eb-45f0-888d-33573eb78f58@hartkopp.net> (raw)
In-Reply-To: <fc7ea750-78bf-42a6-ba3e-4db53a24ca25@hartkopp.net>

On 16.01.26 14:10, Oliver Hartkopp wrote:
> On 16.01.26 13:44, Marc Kleine-Budde wrote:

>> However, in commit 166e87329ce6 ("can: propagate CAN device capabilities
>> via ml_priv"), the capabilities of CAN devices are not initialized.
>> This results in CAN-RAW rejecting all CAN frames on devices directly
>> after ifup if the user space has not changed the CAN control mode.
> 
> Ah! It's about setting the bitrate without changing the control mode.
> 
> Sorry. I tested multiple configurations several times but missed the 
> most simple one as initial test :-/
> 
> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>

Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>



  reply	other threads:[~2026-01-16 14:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 12:44 Marc Kleine-Budde
2026-01-16 12:46 ` Marc Kleine-Budde
2026-01-16 13:10 ` Oliver Hartkopp
2026-01-16 14:45   ` Oliver Hartkopp [this message]
2026-01-16 15:28 ` Markus Elfring
2026-01-16 17:07 ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137dcd58-32eb-45f0-888d-33573eb78f58@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=kernel@pengutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®