From: Luca Coelho <luca@coelho.fi>
To: Felipe Balbi <balbi@ti.com>
Cc: ben@decadent.org.uk,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-wireless@vger.kernel.org, Pavel Machek <pavel@denx.de>
Subject: Re: [PATCH] ti-connectivity: add wl1251 firmware and license
Date: Wed, 25 Sep 2013 14:04:56 +0300 [thread overview]
Message-ID: <1380107096.4503.8.camel@porter.coelho.fi> (raw)
In-Reply-To: <1380033894-5007-1-git-send-email-balbi@ti.com>
Hi dude,
Great, this is cool! Finally! :)
A few comments...
On Tue, 2013-09-24 at 09:44 -0500, Felipe Balbi wrote:
> It's way overdue that we send these firmware
> blobs upstream. Thanks for everybody involved
> in getting this sorted out.
>
> Cc: Luciano Coelho <luca@coelho.fi>
> Cc: Pavel Machek <pavel@denx.de>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
The commit message could be a bit more descriptive rather than
narrative?
> ti-connectivity/license-wl1251.txt | 59 +++++++++++++++++++++++++++++++++++++
The license file should be in the root, together with the other licenses
and called LICENCE.wl1251 (note the en-GB spelling). Also, this license
is *very* similar to the one for WiLink6/7/8 (LICENCE.ti-connectivity),
except for some very minor things and the formatting. Couldn't the same
one be used, for the sake of simplicity and consistency?
> ti-connectivity/wl1251-fw.bin | Bin 0 -> 194180 bytes
> ti-connectivity/wl1251-nvs.bin | Bin 0 -> 752 bytes
> 3 files changed, 59 insertions(+)
> create mode 100644 ti-connectivity/license-wl1251.txt
> create mode 100644 ti-connectivity/wl1251-fw.bin
> create mode 100644 ti-connectivity/wl1251-nvs.bin
When sending big binary blobs, it's generally better to send pull
requests instead of patches. If you add the -p option when calling git
pull-request, the text will include all the readable parts but will omit
the binary stuff.
Thank you very much for following up on this!
--
Cheers,
Luca.
next prev parent reply other threads:[~2013-09-25 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 14:44 Felipe Balbi
2013-09-25 11:04 ` Luca Coelho [this message]
2013-09-25 11:07 ` Luca Coelho
2013-09-25 13:23 ` Felipe Balbi
2013-09-25 13:42 ` Luca Coelho
2013-09-25 13:59 ` Felipe Balbi
2013-10-02 12:55 ` [GIT PULL] firmware: wl1251 firmware binary Felipe Balbi
2013-10-04 5:01 ` Luca Coelho
2013-10-04 15:32 ` Felipe Balbi
2013-10-04 19:43 ` Luca Coelho
2013-10-13 20:12 ` Ben Hutchings
2013-09-30 3:37 ` [PATCH] ti-connectivity: add wl1251 firmware and license Ben Hutchings
2013-09-30 13:32 ` Felipe Balbi
2013-09-25 12:54 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380107096.4503.8.camel@porter.coelho.fi \
--to=luca@coelho.fi \
--cc=balbi@ti.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®