From: Joe Perches <joe@perches.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@shadowen.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum
Date: Wed, 25 Sep 2013 12:48:35 -0700 [thread overview]
Message-ID: <1380138515.17366.22.camel@joe-AO722> (raw)
In-Reply-To: <20130925193035.GA11905@thunk.org>
On Wed, 2013-09-25 at 15:30 -0400, Theodore Ts'o wrote:
> On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote:
> >
> > > * labels a-la Enomem, etc. I've been using those and I will
> > > keep doing so, checkpatch.pl and its users be damned.
> >
> > Good on you.
>
> I'm with Al. This is just silly to add to checkpatch.
>
> > Fine by me. Don't use checkpatch. No stress from me.
>
> I still get some of your minions sending patches asking to "fix" ext4
> from time to time. It wastes everyone's time.
ext4 still has several code style nits that could be
improved. Up to you to do anything about them though.
no space after comma, pointer spaces, and split strings
are nits.
> BTW, checkpatch barfs on pretty much everything in
> linux/trace/events/*.h
include/trace/events/*.h
As I've said multiple times, checkpatch is a stupid
little tool that can be ignored by anyone with
different tastes.
And, shrug. I think straining for alignment like below
doesn't really add much.
$ ./scripts/checkpatch.pl -f include/trace/events/jbd.h
ERROR: space prohibited after that open parenthesis '('
#17: FILE: trace/events/jbd.h:17:
+ __field( dev_t, dev )
ERROR: space prohibited before that close parenthesis ')'
#17: FILE: trace/events/jbd.h:17:
+ __field( dev_t, dev )
ERROR: space prohibited after that open parenthesis '('
#18: FILE: trace/events/jbd.h:18:
+ __field( int, result )
next prev parent reply other threads:[~2013-09-25 19:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 18:38 Joe Perches
2013-09-25 15:24 ` Al Viro
2013-09-25 15:35 ` Joe Perches
2013-09-25 16:19 ` Al Viro
2013-09-25 17:27 ` Alexander Holler
2013-09-25 19:22 ` Joe Perches
2013-09-25 19:30 ` Theodore Ts'o
2013-09-25 19:48 ` Joe Perches [this message]
2013-09-25 19:54 ` Alexander Holler
2013-09-25 20:03 ` Andrew Morton
2013-09-25 20:23 ` Al Viro
2013-09-26 1:10 ` Theodore Ts'o
2013-09-26 1:13 ` Andrew Morton
2013-09-25 20:11 ` Al Viro
2013-09-26 0:38 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380138515.17366.22.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®