From: "Woodhouse, David" <david.woodhouse@intel.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"arm@kernel.org" <arm@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [GIT PULL] ARM: SoC fixes for 3.12-rc
Date: Fri, 27 Sep 2013 10:59:16 +0000 [thread overview]
Message-ID: <1380279555.28494.171.camel@i7.infradead.org> (raw)
In-Reply-To: <CAN8TOE8Xf9fv9zyY6wof3b9QhqgV=s-cK4V4D6n+Gw4HgacT0g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Thu, 2013-09-19 at 17:44 -0700, Brian Norris wrote:
> > Does that m25p80 'fix 4 byte addressing' fix for Micron not also want to
> > go in?
>
> I suppose the m25p80 one can go in as well. It's not so much a bugfix
> as augmenting my original patch to support more devices. But it is
> safe enough.
You say 'support more devices', but AFAICT the code in -rc1 will already
*attempt* to enable 4-byte addressing on those devices, and fail.
(It looks like set_4byte() can return failure, but its return code isn't
checked, and anyway it's only a SPI write so there's no feedback from
the *chip* if it fails due to lack of WREN; it can only indicate failure
if the SPI connection falls over.)
So I'm inclined to think of it as a bug fix and include it.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6242 bytes --]
next prev parent reply other threads:[~2013-09-27 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 19:47 Olof Johansson
2013-09-19 21:39 ` Woodhouse, David
2013-09-19 22:12 ` Olof Johansson
2013-09-19 22:57 ` Brian Norris
2013-09-19 23:19 ` Woodhouse, David
2013-09-20 0:44 ` Brian Norris
2013-09-27 10:59 ` Woodhouse, David [this message]
2013-09-27 17:40 ` Brian Norris
2013-10-03 5:02 ` Brian Norris
-- strict thread matches above, loose matches on Subject: below --
2013-10-25 10:21 Olof Johansson
2013-10-13 16:43 Olof Johansson
2013-10-03 4:15 Olof Johansson
2013-09-12 20:01 Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380279555.28494.171.camel@i7.infradead.org \
--to=david.woodhouse@intel.com \
--cc=arm@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=olof@lixom.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®