From: Abbas Raza <abbas_raza@mentor.com>
To: linux-kernel@vger.kernel.org
Cc: Abbas Raza <Abbas_Raza@mentor.com>
Subject: [PATCH] kthread_bind: don't wait in kthread_bind for presmp initcalls
Date: Fri, 27 Sep 2013 21:47:31 +0500 [thread overview]
Message-ID: <1380300451-396-1-git-send-email-abbas_raza@mentor.com> (raw)
From: Abbas Raza <Abbas_Raza@mentor.com>
wait_task_inactive shouldn't be called in __kthread_bind for presmp
initcalls the same way it is done in !SMP case.
more info here:
http://permalink.gmane.org/gmane.linux.kernel.embedded/4046
This patch improves boot time for pre-smp initcalls as given below
boot time with this patch:
calling spawn_ksoftirqd+0x0/0x30 @ 1
initcall spawn_ksoftirqd+0x0/0x30 returned 0 after 0 usecs
boot time without this patch:
calling spawn_ksoftirqd+0x0/0x30 @ 1
initcall spawn_ksoftirqd+0x0/0x30 returned 0 after 19531 usecs
Signed-off-by: Abbas Raza <Abbas_Raza@mentor.com>
---
kernel/kthread.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index 760e86d..28b5c4b 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -290,11 +290,17 @@ EXPORT_SYMBOL(kthread_create_on_node);
static void __kthread_bind(struct task_struct *p, unsigned int cpu, long state)
{
- /* Must have done schedule() in kthread() before we set_task_cpu */
- if (!wait_task_inactive(p, state)) {
- WARN_ON(1);
- return;
+ if (!((num_online_cpus() == 1) && !cpu)) {
+ /*
+ * Must have done schedule() in kthread() before
+ * we set_task_cpu
+ */
+ if (!wait_task_inactive(p, state)) {
+ WARN_ON(1);
+ return;
+ }
}
+
/* It's safe because the task is inactive. */
do_set_cpus_allowed(p, cpumask_of(cpu));
p->flags |= PF_NO_SETAFFINITY;
--
1.8.3.2
next reply other threads:[~2013-09-27 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 16:47 Abbas Raza [this message]
2013-10-30 16:00 ` Abbas Raza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380300451-396-1-git-send-email-abbas_raza@mentor.com \
--to=abbas_raza@mentor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®