From: Huacai Chen <chenhc@lemote.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Huacai Chen <chenhc@lemote.com>
Subject: [PATCH] genirq: Avoid NULL OOPS in irq handling
Date: Sat, 28 Sep 2013 10:11:24 +0800 [thread overview]
Message-ID: <1380334284-12690-1-git-send-email-chenhc@lemote.com> (raw)
Some devices (e.g. serial port) setup irq handler at dev open and free
it at dev close. So, sometimes there is no irqaction for a specific
irq. But some buggy devices may send irqs at any time. This patch avoid
the NULL OOPS when irqaction isn't registered.
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
kernel/irq/handle.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
index 131ca17..1c78e69 100644
--- a/kernel/irq/handle.c
+++ b/kernel/irq/handle.c
@@ -135,6 +135,9 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
irqreturn_t retval = IRQ_NONE;
unsigned int flags = 0, irq = desc->irq_data.irq;
+ if (!action)
+ goto out;
+
do {
irqreturn_t res;
@@ -174,6 +177,7 @@ handle_irq_event_percpu(struct irq_desc *desc, struct irqaction *action)
add_interrupt_randomness(irq, flags);
+out:
if (!noirqdebug)
note_interrupt(irq, desc, retval);
return retval;
--
1.7.7.3
next reply other threads:[~2013-09-28 2:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 2:11 Huacai Chen [this message]
2013-10-29 13:07 ` Thomas Gleixner
2013-10-30 9:24 ` "陈华才"
2013-10-30 10:06 ` Thomas Gleixner
2013-10-30 13:02 ` "陈华才"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380334284-12690-1-git-send-email-chenhc@lemote.com \
--to=chenhc@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®