From: "Geyslan G. Bem" <geyslan@gmail.com>
To: ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net
Cc: v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Geyslan G. Bem" <geyslan@gmail.com>
Subject: [PATCH] 9p: fix return value in case of error in v9fs_fid_xattr_set
Date: Sat, 28 Sep 2013 20:32:17 -0300 [thread overview]
Message-ID: <1380411144-9236-5-git-send-email-geyslan@gmail.com> (raw)
In-Reply-To: <1380411144-9236-1-git-send-email-geyslan@gmail.com>
In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its negative value, what was never being done.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
fs/9p/xattr.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c
index 3c28cdf..0788388 100644
--- a/fs/9p/xattr.c
+++ b/fs/9p/xattr.c
@@ -149,11 +149,10 @@ int v9fs_fid_xattr_set(struct p9_fid *fid, const char *name,
write_count = value_len;
write_count = p9_client_write(fid, ((char *)value)+offset,
NULL, offset, write_count);
- if (write_count < 0) {
- /* error in xattr write */
- retval = write_count;
- break;
- }
+ /* error in xattr write */
+ if (write_count < 0)
+ return write_count;
+
offset += write_count;
value_len -= write_count;
}
--
1.8.4
next prev parent reply other threads:[~2013-09-28 23:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 23:32 [PATCH] 9p: remove unused 'p9_fid' struct pointer Geyslan G. Bem
2013-09-28 23:32 ` [PATCH] 9p: remove unused 'p9_client' " Geyslan G. Bem
2013-09-28 23:32 ` [PATCH] 9p: remove useless assignment Geyslan G. Bem
2013-09-28 23:32 ` [PATCH] 9p: remove unused 'super_block' struct pointer Geyslan G. Bem
2013-09-28 23:32 ` Geyslan G. Bem [this message]
[not found] ` <CAFkjPTkKeEFmVWoPFXhAkBwwO67M1K-c1Q2OUvajSArTSgrFvg@mail.gmail.com>
2013-10-21 10:47 ` [PATCH] 9p: fix return value in case of error in v9fs_fid_xattr_set Geyslan Gregório Bem
2013-10-21 19:52 ` Geyslan Gregório Bem
2013-09-28 23:32 ` [PATCH] 9p: remove never used return variable Geyslan G. Bem
2013-09-28 23:32 ` [PATCH] 9p: remove useless variable and assignment Geyslan G. Bem
2013-09-28 23:32 ` [PATCH] 9p: proper use of the 'name' variable Geyslan G. Bem
[not found] ` <CAFkjPTmg26H0RGdHmR2u-wuJF=Jhd4PbbG1hVrBucuWyZDgNAw@mail.gmail.com>
2013-10-21 10:53 ` Geyslan Gregório Bem
2013-10-21 19:00 ` Geyslan Gregório Bem
2013-09-28 23:32 ` [PATCH v3 1/2] binfmt_aout: x86: Useless inode var, printks coding style fixes Geyslan G. Bem
2013-09-28 23:41 ` Geyslan Gregório Bem
2013-09-28 23:32 ` [PATCH 1/1] fs/binfmt_elf.c: fill_note_info: Reduce scope of a variable Geyslan G. Bem
2013-09-28 23:42 ` Geyslan Gregório Bem
2013-09-28 23:32 ` [PATCH] fs: exec.c: Coding style sanitization Geyslan G. Bem
2013-09-28 23:41 ` Geyslan Gregório Bem
2013-09-28 23:32 ` [PATCH v3 2/2] ia32_aout: x86_64: Add safe check in a.out loaders, printks, conding style fixes Geyslan G. Bem
2013-09-28 23:41 ` Geyslan Gregório Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380411144-9236-5-git-send-email-geyslan@gmail.com \
--to=geyslan@gmail.com \
--cc=ericvh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=rminnich@sandia.gov \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome