From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@linux.intel.com>, tglx@linutronix.de
Subject: [PATCH 03/11] posix-timers: Initialize timer value to 0 for invalid timers.
Date: Mon, 30 Sep 2013 13:29:04 -0700 [thread overview]
Message-ID: <1380572952-30729-4-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1380572952-30729-1-git-send-email-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
cpu_clock_sample et.al. can fail with an invalid timer type.
For most callers this cannot happen because the timer has been
successfully initialized earlier, so they don't check
the return value, but still use the val output.
Unfortunately static checkers for uninitialied variables
don't understand this and always throw a warning in this case.
Initialize the timer value to 0 for the error case to
shut it up.
This doesn't fix any real bug, just reduces warning noise.
Cc: tglx@linutronix.de
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
kernel/posix-cpu-timers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index c7f31aa..cc3c3f2 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -182,6 +182,7 @@ static int cpu_clock_sample(const clockid_t which_clock, struct task_struct *p,
{
switch (CPUCLOCK_WHICH(which_clock)) {
default:
+ *sample = 0;
return -EINVAL;
case CPUCLOCK_PROF:
*sample = prof_ticks(p);
@@ -243,6 +244,7 @@ static int cpu_clock_sample_group(const clockid_t which_clock,
switch (CPUCLOCK_WHICH(which_clock)) {
default:
+ *sample = 0;
return -EINVAL;
case CPUCLOCK_PROF:
thread_group_cputime(p, &cputime);
--
1.8.3.1
next prev parent reply other threads:[~2013-09-30 20:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 20:29 Various static checker fixes Andi Kleen
2013-09-30 20:29 ` [PATCH 01/11] random: don't feed stack data into pool when interrupt regs NULL Andi Kleen
2013-09-30 20:51 ` Luck, Tony
2013-10-01 12:44 ` Theodore Ts'o
2014-04-04 16:54 ` Sebastian Andrzej Siewior
2014-04-07 4:01 ` Theodore Ts'o
2014-04-07 19:30 ` Sebastian Andrzej Siewior
2014-04-07 23:26 ` Theodore Ts'o
2014-04-09 18:14 ` rkuo
2013-09-30 20:29 ` [PATCH 02/11] Disable initialized_var for clang Andi Kleen
2013-09-30 20:29 ` Andi Kleen [this message]
2013-09-30 20:29 ` [PATCH 04/11] block: Return error code of elevator init function Andi Kleen
2013-10-01 12:25 ` Jeff Moyer
2013-09-30 20:29 ` [PATCH 05/11] seq_file: Handle ->next error in seq_read Andi Kleen
2013-09-30 20:29 ` [PATCH 06/11] sysctl: remove unnecessary variable initialization Andi Kleen
2013-09-30 20:29 ` [PATCH 07/11] igb: Avoid uninitialized advertised variable in eee_set_cur Andi Kleen
2013-10-01 15:00 ` Wyborny, Carolyn
2013-10-01 23:10 ` Jeff Kirsher
2013-10-02 20:33 ` David Miller
2013-09-30 20:29 ` [PATCH 08/11] ext4: Fix end of group handling in ext4_mb_init_cache Andi Kleen
2013-10-01 12:45 ` Theodore Ts'o
2013-10-01 14:20 ` Andi Kleen
2013-09-30 20:29 ` [PATCH 09/11] epoll: Remove unnecessary error path Andi Kleen
2013-09-30 20:59 ` Eric Wong
2013-09-30 21:01 ` Andi Kleen
2013-09-30 20:29 ` [PATCH 10/11] tcp: Always set options to 0 before calling tcp_established_options Andi Kleen
2013-10-02 20:33 ` David Miller
2013-09-30 20:29 ` [PATCH 11/11] perf: Avoid uninitialized sample type reference in __perf_event__output_id_sample Andi Kleen
2013-10-02 8:57 ` Peter Zijlstra
2013-10-02 17:25 ` Andi Kleen
2013-10-02 17:36 ` Peter Zijlstra
2013-10-03 6:42 ` Ingo Molnar
2013-10-03 18:16 ` Andi Kleen
2013-10-04 6:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380572952-30729-4-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome