From: Joe Perches <joe@perches.com>
To: "Mathieu Rhéaume" <mathieu@codingrhemes.com>
Cc: gregkh@linuxfoundation.org, arve@android.com,
dan.carpenter@oracle.com, mirsal@mirsal.fr,
serban.constantinescu@arm.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging : android: binder.c: Prefer seq_puts to seq_printf
Date: Tue, 01 Oct 2013 21:06:22 -0700 [thread overview]
Message-ID: <1380686782.2081.28.camel@joe-AO722> (raw)
In-Reply-To: <1380686239-15208-1-git-send-email-mathieu@codingrhemes.com>
On Tue, 2013-10-01 at 23:57 -0400, Mathieu Rhéaume wrote:
> Changes since v2:
> * Fixed the indent problems (2 tab and 1 space) by Joe Perches.
> * Found more calls to convert from seq_printf to seq_puts
[]
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -3272,33 +3272,33 @@ binder_defer_work(struct binder_proc *proc, enum binder_deferred_state defer)
> static void print_binder_transaction(struct seq_file *m, const char *prefix,
> struct binder_transaction *t)
> {
> - seq_printf(m,
> - "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
> - prefix, t->debug_id, t,
> - t->from ? t->from->proc->pid : 0,
> - t->from ? t->from->pid : 0,
> - t->to_proc ? t->to_proc->pid : 0,
> - t->to_thread ? t->to_thread->pid : 0,
> - t->code, t->flags, t->priority, t->need_reply);
> + seq_puts(m, "%s %d: %p from %d:%d to %d:%d code %x flags %x pri %ld r%d",
Only indent the subsequent lines
not the initial seq_puts.
prev parent reply other threads:[~2013-10-02 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 3:57 Mathieu Rhéaume
2013-10-02 4:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380686782.2081.28.camel@joe-AO722 \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu@codingrhemes.com \
--cc=mirsal@mirsal.fr \
--cc=serban.constantinescu@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®