From: Boris BREZILLON <b.brezillon@overkiz.com>
To: Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Wim Van Sebroeck <wim@iguana.be>,
Fabio Porcedda <fabio.porcedda@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Guenter Roeck <groeck7@gmail.com>,
Yang Wenyou <wenyou.yang@atmel.com>
Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-watchdog@vger.kernel.org,
Boris BREZILLON <b.brezillon@overkiz.com>
Subject: [PATCH v4 0/4] watchdog: at91sam9_wdt: handle already configured wdt
Date: Thu, 3 Oct 2013 21:04:39 +0200 [thread overview]
Message-ID: <1380827083-6872-1-git-send-email-b.brezillon@overkiz.com> (raw)
Hello,
This patch series is a porposal to enhance the sam9 watchdog timer support.
The at91sam9 watchdog timer can only be configured once, and the current
implementation tries to configure it in a static way:
- 2 seconds timeout
- wdt restart every 500ms
If the timer has already been configured with different values, it returns an
error and do not create any watchdog device.
This is not critical if the watchdog is disabled, but if it has been enabled
with different timeout values it will lead to a SoC reset.
This patch series tries to address this issue by adapting the heartbeat value
according the WDT timer config:
- it first tries to configure the timer as requested.
- if it fails it fallbacks to the current config, adapting its heartbeat timer
to the needs
This patch series also move to a dynamically allocated at91wdt device instead
of the static instance. I'm not sure this is the best solution, so please tell
me if you prefer to keep static instance of watchdog.
It adds a new at91 wdt type: software. This new type make use of the at91 wdt
interrupt to trigger a software reboot.
Finally it adds several properties to the device tree bindings.
Best Regards,
Boris
Changes since v3:
- fix a bug in heartbeat time computation
- fix a bug in at91_wdt_set_timeout when new timeout is bigger than the old
one
- rename at91_wdt_ping into at91_wdt_start
- remove unneeded ping callback assignment
Changes since v2:
- fix documentation
- rework the heartbeat computation to get a more flexible behaviour
- fix xx_to_yy macros
- modify warning and error messages
- remove unneeded parenthesis in arithmetic operations
- use devm functions to map io memory
- remove unneeded devm_kfree calls
Change since v1:
- fix typo in documentaion
- fix irq dt definition for sama5d3 SoC
Boris BREZILLON (4):
watchdog: at91sam9_wdt: better watchdog support
watchdog: at91sam9_wdt: update device tree doc
ARM: at91/dt: add sam9 watchdog default options to SoCs
ARM: at91/dt: add watchdog properties to kizbox board
.../devicetree/bindings/watchdog/atmel-wdt.txt | 30 +-
arch/arm/boot/dts/at91sam9260.dtsi | 5 +
arch/arm/boot/dts/at91sam9263.dtsi | 5 +
arch/arm/boot/dts/at91sam9g45.dtsi | 5 +
arch/arm/boot/dts/at91sam9n12.dtsi | 5 +
arch/arm/boot/dts/at91sam9x5.dtsi | 5 +
arch/arm/boot/dts/kizbox.dts | 6 +
arch/arm/boot/dts/sama5d3.dtsi | 5 +
drivers/watchdog/at91sam9_wdt.c | 305 ++++++++++++++------
9 files changed, 285 insertions(+), 86 deletions(-)
--
1.7.9.5
next reply other threads:[~2013-10-03 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 19:04 Boris BREZILLON [this message]
2013-10-03 19:04 ` [PATCH v4 1/4] watchdog: at91sam9_wdt: better watchdog support Boris BREZILLON
2013-10-04 2:38 ` Guenter Roeck
2013-10-03 19:04 ` [PATCH v4 2/4] watchdog: at91sam9_wdt: update device tree doc Boris BREZILLON
2013-10-03 19:04 ` [PATCH v4 3/4] ARM: at91/dt: add sam9 watchdog default options to SoCs Boris BREZILLON
2013-10-03 19:04 ` [PATCH v4 4/4] ARM: at91/dt: add watchdog properties to kizbox board Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380827083-6872-1-git-send-email-b.brezillon@overkiz.com \
--to=b.brezillon@overkiz.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.porcedda@gmail.com \
--cc=groeck7@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=wenyou.yang@atmel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®