From: Joe Perches <joe@perches.com>
To: Matthias Beyer <mail@beyermatthias.de>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers: usb: core: hcd: Whitespace fixes
Date: Sat, 05 Oct 2013 11:04:04 -0700 [thread overview]
Message-ID: <1380996244.2081.125.camel@joe-AO722> (raw)
In-Reply-To: <e5dba9e89cd8c98d7d2f2578b72482ccf0a4ea88.1380986962.git.mail@beyermatthias.de>
On Sat, 2013-10-05 at 18:02 +0200, Matthias Beyer wrote:
> - removing spaces before array indexing (foo [] to foo[])
[]
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
[]
> @@ -93,7 +93,7 @@ EXPORT_SYMBOL_GPL (usb_bus_list);
> /* used when allocating bus numbers */
> #define USB_MAXBUS 64
> struct usb_busmap {
> - unsigned long busmap [USB_MAXBUS / (8*sizeof (unsigned long))];
> + unsigned long busmap[USB_MAXBUS / (8*sizeof (unsigned long))];
this would be nicer as
DEFINE_BITMAP(busmap, USB_MAXBUS);
next prev parent reply other threads:[~2013-10-05 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-05 16:02 [PATCH 0/5] Cleanup in drivers/usb/core/hcd.c Matthias Beyer
2013-10-05 16:02 ` [PATCH 1/5] drivers: usb: core: hcd: moved asterix to variable Matthias Beyer
2013-10-06 21:52 ` Sergei Shtylyov
2013-10-05 16:02 ` [PATCH 2/5] drivers: usb: core: hcd: Whitespace fixes Matthias Beyer
2013-10-05 18:04 ` Joe Perches [this message]
2013-10-05 18:05 ` Joe Perches
2013-10-05 21:09 ` [PATCH 1/1] drivers: usb: core: hcd.c: converted busmap from struct to bitmap Matthias Beyer
2013-10-05 16:02 ` [PATCH 3/5] drivers: usb: core: hcd: replaced C99 // comments Matthias Beyer
2013-10-05 16:02 ` [PATCH 4/5] drivers: usb: core: hcd: removed braces for return statements Matthias Beyer
2013-10-05 16:02 ` [PATCH 5/5] drivers: usb: core: hcd: if-else-braces fixed Matthias Beyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380996244.2081.125.camel@joe-AO722 \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®