From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Josh Triplett <josh@joshtriplett.org>,
torvalds@linux-foundation.org, gregkh@linux-foundation.org,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] checkpatch: Make the 80-character limit a --strict check only
Date: Mon, 07 Oct 2013 14:41:55 -0700 [thread overview]
Message-ID: <1381182115.2081.218.camel@joe-AO722> (raw)
In-Reply-To: <1381181602.2081.214.camel@joe-AO722>
On Mon, 2013-10-07 at 14:33 -0700, Joe Perches wrote:
> On Mon, 2013-10-07 at 22:23 +0100, Al Viro wrote:
> > On Mon, Oct 07, 2013 at 12:34:33PM -0700, Josh Triplett wrote:
> >
> > > I've seen far more examples of the 80-column limit making code less
> > > readable rather than more. It's only really helpful when it forces code
> > > restructuring, *not* when it just forces an arbitrary line break.
> >
> > So teach that piece of crap to complain about fucked-in-head line breaks like
> > ret_val =
> > leaf_shift_left(tb,
> > tb->
> > lnum
> > [0],
> > tb->
> > lbytes
> > -
> > 1);
> > in addition to obscenely long lines (and yes, it is a real-world example).
btw: checkpatch does suggest refactoring when there are
6+ indent tabs with an if/while/for/do/switch statement.
so it already does bleat around there.
next prev parent reply other threads:[~2013-10-07 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 19:18 Josh Triplett
2013-10-07 19:28 ` Joe Perches
2013-10-07 19:34 ` Josh Triplett
2013-10-07 19:38 ` Joe Perches
2013-10-08 2:08 ` Josh Triplett
2013-10-07 21:23 ` Al Viro
2013-10-07 21:33 ` Joe Perches
2013-10-07 21:41 ` Joe Perches [this message]
2013-10-07 19:50 ` Richard Weinberger
2013-10-07 21:40 ` Andi Kleen
2013-10-08 4:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381182115.2081.218.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=gregkh@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®