From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755124Ab3JHNgw (ORCPT ); Tue, 8 Oct 2013 09:36:52 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:15026 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753892Ab3JHNgs (ORCPT ); Tue, 8 Oct 2013 09:36:48 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 08 Oct 2013 06:32:40 -0700 From: Laxman Dewangan To: CC: , , , Laxman Dewangan Subject: [PATCH] regulator: tps6586x: get regulators node from parent node only Date: Tue, 8 Oct 2013 19:31:03 +0530 Message-ID: <1381240864-19639-2-git-send-email-ldewangan@nvidia.com> X-Mailer: git-send-email 1.7.1.1 In-Reply-To: <1381240864-19639-1-git-send-email-ldewangan@nvidia.com> References: <1381240864-19639-1-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As per the devicetree binding document of TPS6586x, the "regulators" subnode should be under the parent node, not outside of parent node. Hence to get the regulator node, the correct call is of_get_child_by_name() rather than of_find_node_by_name() which searches the "regulators" node from the parent node to end of DTS file. Signed-off-by: Laxman Dewangan --- drivers/regulator/tps6586x-regulator.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c index 45e5d68..e8e3a8a 100644 --- a/drivers/regulator/tps6586x-regulator.c +++ b/drivers/regulator/tps6586x-regulator.c @@ -298,7 +298,7 @@ static struct tps6586x_platform_data *tps6586x_parse_regulator_dt( struct tps6586x_platform_data *pdata; int err; - regs = of_find_node_by_name(np, "regulators"); + regs = of_get_child_by_name(np, "regulators"); if (!regs) { dev_err(&pdev->dev, "regulator node not found\n"); return NULL; -- 1.7.1.1