From: Joe Perches <joe@perches.com>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH] core: Catch overflows in do_div() function
Date: Tue, 08 Oct 2013 09:18:10 -0700 [thread overview]
Message-ID: <1381249090.2081.240.camel@joe-AO722> (raw)
In-Reply-To: <1381248622-27809-1-git-send-email-anatol.pomozov@gmail.com>
On Tue, 2013-10-08 at 09:10 -0700, Anatol Pomozov wrote:
> If second parameter passed to this function was 64 then it silently
> truncates to 32 bits. Catch such situation.
[]
> diff --git a/include/asm-generic/div64.h b/include/asm-generic/div64.h
[]
> @@ -25,6 +26,7 @@
> # define do_div(n,base) ({ \
> uint32_t __base = (base); \
> uint32_t __rem; \
> + BUG_ON(sizeof(base) > 4 && base >= (1UL<<32)); \
I think this would be better as a BUILD_BUG_ON
next prev parent reply other threads:[~2013-10-08 16:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 17:21 do_div() silently truncates "base" to 32bit Anatol Pomozov
2013-08-30 21:23 ` Randy Dunlap
2013-08-30 22:14 ` Anatol Pomozov
2013-08-30 22:48 ` Randy Dunlap
2013-08-30 23:28 ` Joe Perches
2013-08-31 0:50 ` Anatol Pomozov
2013-09-04 15:32 ` Anatol Pomozov
2013-09-04 17:20 ` Randy Dunlap
2013-10-08 16:10 ` [PATCH] core: Catch overflows in do_div() function Anatol Pomozov
2013-10-08 16:18 ` Joe Perches [this message]
2013-10-08 16:45 ` Richard Weinberger
2013-10-08 16:51 ` Joe Perches
2013-10-08 17:28 ` Anatol Pomozov
2013-10-08 17:40 ` Anatol Pomozov
2013-10-08 17:15 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381249090.2081.240.camel@joe-AO722 \
--to=joe@perches.com \
--cc=anatol.pomozov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®