mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Salter <msalter@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Salter <msalter@redhat.com>
Subject: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script
Date: Tue,  8 Oct 2013 16:37:39 -0400	[thread overview]
Message-ID: <1381264659-11132-1-git-send-email-msalter@redhat.com> (raw)

The arm64 linker script doesn't use the PAGE_ALIGNED_DATA macro which
leads to a ".data..page_aligned" section being placed between the end
of .data and start of .bss:

 % readelf -e vmlinux
   ...
 Section to Segment mapping:
  Segment Sections...
   00     .head.text .text .text.init .rodata __ksymtab __ksymtab_gpl \
          __ksymtab_strings __param __modver __ex_table .notes \
          .init.text .init.data .data..percpu .data .data..page_aligned .bss

This causes problems for the EFI stub which may have to relocate the
kernel image based on stext and _edata symbols.

This patch adds PAGE_ALIGNED_DATA() to the linker script inside the
the .data section.

Signed-off-by: Mark Salter <msalter@redhat.com>
---
 arch/arm64/kernel/vmlinux.lds.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/vmlinux.lds.S b/arch/arm64/kernel/vmlinux.lds.S
index f8ab9d8..e441556 100644
--- a/arch/arm64/kernel/vmlinux.lds.S
+++ b/arch/arm64/kernel/vmlinux.lds.S
@@ -110,6 +110,7 @@ SECTIONS
 		 */
 		INIT_TASK_DATA(THREAD_SIZE)
 		NOSAVE_DATA
+		PAGE_ALIGNED_DATA(PAGE_SIZE)
 		CACHELINE_ALIGNED_DATA(64)
 		READ_MOSTLY_DATA(64)
 
-- 
1.8.3.1


             reply	other threads:[~2013-10-08 20:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 20:37 Mark Salter [this message]
2013-10-09 10:14 ` Will Deacon
2013-10-09 17:31   ` Mark Salter
2013-10-11 12:18   ` Mark Salter
2013-11-01 15:01     ` Mark Salter
2013-11-01 16:17       ` Will Deacon
2013-11-04 11:28     ` Catalin Marinas
2013-11-04 16:38       ` [PATCH] arm64: use generic RW_DATA_SECTION macro in " Mark Salter
2013-11-04 17:20         ` Will Deacon
2013-11-04 18:19         ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381264659-11132-1-git-send-email-msalter@redhat.com \
    --to=msalter@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome