mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dan Rosenberg <dan.j.rosenberg@gmail.com>,
	Rob Landley <rob@landley.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] vsprintf/sysctl: Bugfix, neaten and document %pK usages
Date: Thu, 10 Oct 2013 22:38:30 -0700	[thread overview]
Message-ID: <1381469910.14017.45.camel@joe-AO722> (raw)
In-Reply-To: <52578D37.2000004@gmail.com>

On Fri, 2013-10-11 at 16:31 +1100, Ryan Mallon wrote:
> On 11/10/13 16:25, Joe Perches wrote:
> > Printing kernel pointers via %pK has a minor defect when
> > kptr_restrict is set to 2:  the pointer may be emitted
> > as "pK-error" instead of all 0's when in an interrupt.
> 
> NAK. This is not a defect, as I explained earlier. It is really a defect
> that it _doesn't_ print 'pK-error' in all cases. 'pK-error' is for
> finding kernel bugs.

Not my understanding.

There is no bug to find when emitting a pointer via %pK.

The only issue is that has_capability_noaudit can not
be called from an interrupt.



  reply	other threads:[~2013-10-11  5:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-11  5:25 Joe Perches
2013-10-11  5:25 ` [PATCH 2/2] vsprintf: Just some neatening Joe Perches
2013-10-11  5:31 ` [PATCH 1/2] vsprintf/sysctl: Bugfix, neaten and document %pK usages Ryan Mallon
2013-10-11  5:38   ` Joe Perches [this message]
2013-10-11  5:49     ` Ryan Mallon
2013-10-11  5:58       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381469910.14017.45.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.rosenberg@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmallon@gmail.com \
    --cc=rob@landley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®