mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Majunath Goudar <csmanjuvijay@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: nataraja.km@lge.com, Majunath Goudar <manju.goudar@lge.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <rob.herring@calxeda.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] ARM: CCI : Fix implicit declaration of function error
Date: Mon, 14 Oct 2013 15:52:27 +0530	[thread overview]
Message-ID: <1381746147-13830-1-git-send-email-manju.goudar@lge.com> (raw)

This patch adds a inline dummy implementations of_find_matching_node()
in "#ifdef CONFIG_OF" else part. Without this patch,build system can
lead to issues. This was discovered during randconfig testing,in which
ARM_CCI was enabled w/o CONFIG_OF being enabled,leading to the following error:

CC      drivers/bus/arm-cci.o
drivers/bus/arm-cci.c: In function ‘cci_probe’:
drivers/bus/arm-cci.c:971:2: error: implicit declaration of function
‘of_find_matching_node’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [drivers/bus/arm-cci.o] Error 1
make[1]: *** [drivers/bus] Error 2
make: *** [drivers] Error 2

Signed-off-by: Manjunath Goudar <manju.goudar@lge.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 include/linux/of.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index f95aee3..2c57aa2 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -340,6 +340,13 @@ int of_device_is_stdout_path(struct device_node *dn);
 
 #else /* CONFIG_OF */
 
+static inline struct device_node *of_find_matching_node(
+	struct device_node *from,
+	const struct of_device_id *matches)
+{
+	return NULL;
+}
+
 static inline const char* of_node_full_name(struct device_node *np)
 {
 	return "<no-node>";
-- 
1.7.9.5


             reply	other threads:[~2013-10-14 10:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 10:22 Majunath Goudar [this message]
2013-10-17 12:12 Dave Martin
2013-11-21 12:56 ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381746147-13830-1-git-send-email-manju.goudar@lge.com \
    --to=csmanjuvijay@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manju.goudar@lge.com \
    --cc=nataraja.km@lge.com \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®