From: Lan Tianyu <tianyu.lan@intel.com>
To: lenb@kernel.org, rjw@rjwysocki.net
Cc: Lan Tianyu <tianyu.lan@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 1/3] ACPI/Power: Add state_lock to mutex power resource's _ON, _OFF and _STA
Date: Tue, 15 Oct 2013 23:04:51 +0800 [thread overview]
Message-ID: <1381849493-7977-2-git-send-email-tianyu.lan@intel.com> (raw)
In-Reply-To: <1381849493-7977-1-git-send-email-tianyu.lan@intel.com>
According commit d0515d9f, power resource's _ON, _OFF and _STA should
be mutexed. This patch is to add state_lock to do this instead of
using resource_lock.
Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
---
drivers/acpi/power.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index 0c1c3ec..fa89d16 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -75,6 +75,7 @@ struct acpi_power_resource {
unsigned int ref_count;
bool wakeup_enabled;
struct mutex resource_lock;
+ struct mutex state_lock;
};
struct acpi_power_resource_entry {
@@ -216,9 +217,9 @@ static int acpi_power_get_list_state(struct list_head *list, int *state)
acpi_handle handle = resource->device.handle;
int result;
- mutex_lock(&resource->resource_lock);
+ mutex_lock(&resource->state_lock);
result = acpi_power_get_state(handle, &cur_state);
- mutex_unlock(&resource->resource_lock);
+ mutex_unlock(&resource->state_lock);
if (result)
return result;
@@ -263,7 +264,10 @@ static int __acpi_power_on(struct acpi_power_resource *resource)
{
acpi_status status = AE_OK;
+ mutex_lock(&resource->state_lock);
status = acpi_evaluate_object(resource->device.handle, "_ON", NULL, NULL);
+ mutex_unlock(&resource->state_lock);
+
if (ACPI_FAILURE(status))
return -ENODEV;
@@ -309,8 +313,11 @@ static int __acpi_power_off(struct acpi_power_resource *resource)
{
acpi_status status;
+ mutex_lock(&resource->state_lock);
status = acpi_evaluate_object(resource->device.handle, "_OFF",
NULL, NULL);
+ mutex_unlock(&resource->state_lock);
+
if (ACPI_FAILURE(status))
return -ENODEV;
@@ -564,7 +571,9 @@ int acpi_power_wakeup_list_init(struct list_head *list, int *system_level_p)
mutex_lock(&resource->resource_lock);
+ mutex_lock(&resource->state_lock);
result = acpi_power_get_state(handle, &state);
+ mutex_unlock(&resource->state_lock);
if (result) {
mutex_unlock(&resource->resource_lock);
return result;
@@ -881,6 +890,7 @@ int acpi_add_power_resource(acpi_handle handle)
device = &resource->device;
acpi_init_device_object(device, handle, ACPI_BUS_TYPE_POWER,
ACPI_STA_DEFAULT);
+ mutex_init(&resource->state_lock);
mutex_init(&resource->resource_lock);
INIT_LIST_HEAD(&resource->dependent);
INIT_LIST_HEAD(&resource->list_node);
@@ -935,7 +945,10 @@ void acpi_resume_power_resources(void)
mutex_lock(&resource->resource_lock);
+ mutex_lock(&resource->state_lock);
result = acpi_power_get_state(resource->device.handle, &state);
+ mutex_unlock(&resource->state_lock);
+
if (result) {
mutex_unlock(&resource->resource_lock);
continue;
--
1.8.2.1
next prev parent reply other threads:[~2013-10-15 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 15:04 [RFC PATCH 0/3] ACPI/Power: Fix infinite loop of runtime resume and suspend caused by turning on power resource Lan Tianyu
2013-10-15 15:04 ` Lan Tianyu [this message]
2013-10-15 15:04 ` [RFC PATCH 2/3] ACPI/POWER: Rework acpi_power_get_state() Lan Tianyu
2013-10-15 15:04 ` [RFC PATCH 3/3] ACPI/POWER: Call acpi_power_resume_dependent() directly in the acpi_power_on_unlocked() Lan Tianyu
2013-10-15 15:12 ` Lan Tianyu
2013-10-15 21:05 ` [RFC PATCH 0/3] ACPI/Power: Fix infinite loop of runtime resume and suspend caused by turning on power resource Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381849493-7977-2-git-send-email-tianyu.lan@intel.com \
--to=tianyu.lan@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®