From: Chuansheng Liu <chuansheng.liu@intel.com>
To: mingo@kernel.org, peterz@infradead.org
Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
Subject: sched/rt: Pick up the throttled rt tasks in case no other non-rt tasks
Date: Wed, 16 Oct 2013 23:43:36 +0800 [thread overview]
Message-ID: <1381938216.26153.63.camel@cliu38-desktop-build> (raw)
Meet the case that on CPU2, there are just two tasks to be run,
one is one rt task A, another is idle task, but at this time,
and the rt_rq is throttled.
CPU1 CPU2
staying in idle task;
waking up rt task A on
target CPU 2;
exiting from idle task;
DO schedule()
pick up RT next task
pick_next_task_rt()
_pick_next_task_rt()
rt_rq is throttled
return NULL rt task to be picked
CPU2 then went into idle task AGAIN;
after 2s, CPU2 is waken up again;
rt task A is get running;
Here rt task A is delayed for some time, even when CPU2 is in idle state.
so in case there are just rt tasks running, we can pick up one of them
even rt_rq is throttled.
Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
---
kernel/sched/rt.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 01970c8..d521050 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1305,8 +1305,16 @@ static struct task_struct *_pick_next_task_rt(struct rq *rq)
if (!rt_rq->rt_nr_running)
return NULL;
- if (rt_rq_throttled(rt_rq))
- return NULL;
+ if (rt_rq_throttled(rt_rq)) {
+ /*
+ * If in current rq, expects for idle task, the other tasks
+ * are rt tasks, we should continue to pick one of the rt tasks.
+ * Otherwise, the rt tasks will be delayed while current
+ * CPU is in idle.
+ */
+ if ((rt_rq->rt_nr_running + 1) != rq->nr_running)
+ return NULL;
+ }
do {
rt_se = pick_next_rt_entity(rq, rt_rq);
--
1.7.9.5
next reply other threads:[~2013-10-16 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 15:43 Chuansheng Liu [this message]
2013-10-16 6:56 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381938216.26153.63.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®