From: David Cohen <david.a.cohen@linux.intel.com>
To: x86@kernel.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com,
Fengguang Wu <fengguang.wu@intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH v10 04/12] pci: intel_mid: return true/false in function returning bool
Date: Thu, 17 Oct 2013 15:35:28 -0700 [thread overview]
Message-ID: <1382049336-21316-5-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1382049336-21316-1-git-send-email-david.a.cohen@linux.intel.com>
From: Fengguang Wu <fengguang.wu@intel.com>
Function 'type1_access_ok' should return bool value, not 0/1.
This patch changes 'return 0/1' to 'return false/true'.
Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: David Cohen <david.a.cohen@linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
arch/x86/pci/intel_mid_pci.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index f8715f7..c5ca5b9 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -150,12 +150,12 @@ static bool type1_access_ok(unsigned int bus, unsigned int devfn, int reg)
* shim. Therefore, use the header type in shim instead.
*/
if (reg >= 0x100 || reg == PCI_STATUS || reg == PCI_HEADER_TYPE)
- return 0;
+ return false;
if (bus == 0 && (devfn == PCI_DEVFN(2, 0)
|| devfn == PCI_DEVFN(0, 0)
|| devfn == PCI_DEVFN(3, 0)))
- return 1;
- return 0; /* Langwell on others */
+ return true;
+ return false; /* Langwell on others */
}
static int pci_read(struct pci_bus *bus, unsigned int devfn, int where,
--
1.8.4.rc3
next prev parent reply other threads:[~2013-10-17 22:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-17 22:35 [PATCH v10 00/12] rework arch/x86/platform/[mrst => intel-mid] David Cohen
2013-10-17 22:35 ` [PATCH v10 01/12] mrst: Fixed printk/pr_* related issues David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 02/12] mrst: Fixed indentation issues David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 03/12] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-18 0:33 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` David Cohen [this message]
2013-10-18 0:33 ` [tip:x86/intel-mid] pci: intel_mid: Return true/ false in function returning bool tip-bot for Fengguang Wu
2013-10-17 22:35 ` [PATCH v10 05/12] intel_mid: Renamed *mrst* to *intel_mid* David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 06/12] intel_mid: Refactored sfi_parse_devs() function David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 07/12] intel_mid: Added custom device_handler support David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 08/12] intel_mid: Added custom handler for ipc devices David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 09/12] intel_mid: Moved SFI related code to sfi.c David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] " tip-bot for Kuppuswamy Sathyanarayanan
2013-10-17 22:35 ` [PATCH v10 10/12] intel-mid: sfi: allow struct devs_id.get_platform_data to be NULL David Cohen
2013-10-18 0:34 ` [tip:x86/intel-mid] intel-mid: sfi: Allow " tip-bot for David Cohen
2013-10-17 22:35 ` [PATCH v10 11/12] x86: intel-mid: add section for sfi device table David Cohen
2013-10-18 0:35 ` [tip:x86/intel-mid] x86: intel-mid: Add " tip-bot for David Cohen
2013-10-17 22:35 ` [PATCH v10 12/12] intel_mid: move board related codes to their own platform_<device>.* files David Cohen
2013-10-18 0:35 ` [tip:x86/intel-mid] intel_mid: Move platform device setups " tip-bot for David Cohen
2013-10-18 6:09 ` [PATCH v10 00/12] rework arch/x86/platform/[mrst => intel-mid] Ingo Molnar
2013-10-18 13:39 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382049336-21316-5-git-send-email-david.a.cohen@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome