From: Chuansheng Liu <chuansheng.liu@intel.com>
To: JBottomley@parallels.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
bitbucket@online.de, chuansheng.liu@intel.com,
dongxing.zhang@intel.com
Subject: [SCSI] scsi_lib: avoid the "rejecting I/O to offline device" print storm
Date: Tue, 22 Oct 2013 23:51:40 +0800 [thread overview]
Message-ID: <1382457100.26153.69.camel@cliu38-desktop-build> (raw)
When handling the scsi_request_fn(), when the sd offline happened, sometimes
we will hit the print storm as below:
<3>[ 95.365837] sd 0:0:0:0: rejecting I/O to offline device
<3>[ 95.368633] sd 0:0:0:0: rejecting I/O to offline device
<3>[ 95.369881] sd 0:0:0:0: rejecting I/O to offline device
<3>[ 95.371088] sd 0:0:0:0: rejecting I/O to offline device
...
<3>[ 99.026230] sd 0:0:0:0: rejecting I/O to offline device
<3>[ 99.027196] sd 0:0:0:0: rejecting I/O to offline device
<3>[ 99.028240] sd 0:0:0:0: rejecting I/O to offline device
In our case, the print last almost 4s, and it causes irq is disbled for 4s,
bring system unstable.
Here we create sd_printk_ratelimited to replace it.
Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
---
drivers/scsi/scsi_lib.c | 2 +-
include/scsi/scsi_device.h | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index d1549b7..7d8d476 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1570,7 +1570,7 @@ static void scsi_request_fn(struct request_queue *q)
break;
if (unlikely(!scsi_device_online(sdev))) {
- sdev_printk(KERN_ERR, sdev,
+ sdev_printk_ratelimited(KERN_ERR, sdev,
"rejecting I/O to offline device\n");
scsi_kill_request(req, q);
continue;
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index d65fbec..0d7d1be 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -7,6 +7,7 @@
#include <linux/blkdev.h>
#include <scsi/scsi.h>
#include <linux/atomic.h>
+#include <linux/ratelimit.h>
struct device;
struct request_queue;
@@ -235,6 +236,15 @@ struct scsi_dh_data {
#define sdev_printk(prefix, sdev, fmt, a...) \
dev_printk(prefix, &(sdev)->sdev_gendev, fmt, ##a)
+#define sdev_printk_ratelimited(prefix, sdev, fmt, a...) \
+do { \
+ static DEFINE_RATELIMIT_STATE(_rs, \
+ DEFAULT_RATELIMIT_INTERVAL, \
+ DEFAULT_RATELIMIT_BURST); \
+ if (__ratelimit(&_rs)) \
+ dev_printk(prefix, &(sdev)->sdev_gendev, fmt, ##a); \
+} while (0)
+
#define scmd_printk(prefix, scmd, fmt, a...) \
(scmd)->request->rq_disk ? \
sdev_printk(prefix, (scmd)->device, "[%s] " fmt, \
--
1.7.9.5
reply other threads:[~2013-10-22 6:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382457100.26153.69.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=JBottomley@parallels.com \
--cc=bitbucket@online.de \
--cc=dongxing.zhang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®