From: Joe Perches <joe@perches.com>
To: Dirk Gouders <dirk@gouders.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC trivial] printk.c: /proc/vmcore instead of /proc/vmcoreinfo in comments?
Date: Tue, 22 Oct 2013 08:57:24 -0700 [thread overview]
Message-ID: <1382457444.2041.82.camel@joe-AO722> (raw)
In-Reply-To: <gik3h5tsbn.fsf@karga.hank.lab>
On Tue, 2013-10-22 at 14:15 +0200, Dirk Gouders wrote:
> Hello Joe,
>
> when having a look at printk.c, I noticed that two comments refer
> to /proc/vmcoreinfo and I wonder if that should not read /proc/vmcore.
>
> While at it, a typo in one of those coments could also be fixed.
Hi Dirk.
Thanks and yes this is sensible.
Adding Andrew Morton to cc's and resending as plain-text
>From 2ef84ff3187633a3156c3a967c1dfc294292e492 Mon Sep 17 00:00:00 2001
From: Dirk Gouders <dirk@gouders.net>
Date: Tue, 22 Oct 2013 13:51:15 +0200
Subject: [PATCH] printk.c: comments should refer to /proc/vmcore instead of
/proc/vmcoreinfo
In one of those comments a typo was fixed, too.
Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
kernel/printk/printk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index b4e8500..694d1f9 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -705,9 +705,9 @@ const struct file_operations kmsg_fops = {
#ifdef CONFIG_KEXEC
/*
- * This appends the listed symbols to /proc/vmcoreinfo
+ * This appends the listed symbols to /proc/vmcore
*
- * /proc/vmcoreinfo is used by various utiilties, like crash and makedumpfile to
+ * /proc/vmcore is used by various utilities, like crash and makedumpfile to
* obtain access to symbols that are otherwise very difficult to locate. These
* symbols are specifically used so that utilities can access and extract the
* dmesg log from a vmcore file after a crash.
--
1.8.3.2
next prev parent reply other threads:[~2013-10-22 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:15 Dirk Gouders
2013-10-22 15:57 ` Joe Perches [this message]
2013-11-06 16:01 ` Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382457444.2041.82.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dirk@gouders.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®