From: Joe Perches <joe@perches.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: mmarek@suse.cz, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, Joe Mario <jmario@redhat.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] kbuild: Increase kallsyms max symbol length
Date: Tue, 22 Oct 2013 09:36:04 -0700 [thread overview]
Message-ID: <1382459764.2041.90.camel@joe-AO722> (raw)
In-Reply-To: <1382456783-22826-2-git-send-email-andi@firstfloor.org>
On Tue, 2013-10-22 at 08:46 -0700, Andi Kleen wrote:
> From: Joe Mario <jmario@redhat.com>
>
> [AK: This seems like a ticking time bomb even without LTO,
> so should be merged now. It causes very weird problems.
> Thanks to Joe for tracking them down.]
>
> With the added postfixes that LTO adds for local
> symbols, the longest name in the kernel overflows
> the namebuf[KSYM_NAME_LEN] array by two bytes. That name is:
> __pci_fixup_resumePCI_VENDOR_ID_SERVERWORKSPCI_DEVICE_ID_SERVERWORKS_HT1000SBquirk_disable_broadcom_boot_interrupt.1488004.672802
>
> Double the max symbol name length.
[]
> diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
> index 6883e19..711a50f 100644
> --- a/include/linux/kallsyms.h
> +++ b/include/linux/kallsyms.h
> @@ -9,7 +9,7 @@
> #include <linux/kernel.h>
> #include <linux/stddef.h>
>
> -#define KSYM_NAME_LEN 128
> +#define KSYM_NAME_LEN 256
Doesn't doubling seems a tad excessive given the
silly length of that symbol above?
next prev parent reply other threads:[~2013-10-22 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 15:46 Some kbuild fixes Andi Kleen
2013-10-22 15:46 ` [PATCH 1/3] kbuild: Increase kallsyms max symbol length Andi Kleen
2013-10-22 16:36 ` Joe Perches [this message]
2013-10-22 16:40 ` Andi Kleen
2013-10-22 16:55 ` Joe Perches
2013-10-23 13:06 ` [PATCH 1/3] kbuild: Increase kallsyms max symbol length v2 Andi Kleen
2013-11-06 21:26 ` Michal Marek
2013-10-22 15:46 ` [PATCH 2/3] Kbuild: Handle longer symbols in kallsyms.c Andi Kleen
2013-10-22 16:36 ` Joe Perches
2013-10-23 13:07 ` [PATCH 2/3] Kbuild: Handle longer symbols in kallsyms.c v2 Andi Kleen
2013-11-06 21:27 ` Michal Marek
2013-10-22 15:46 ` [PATCH 3/3] kbuild, bloat-o-meter: fix static detection Andi Kleen
2013-11-06 21:27 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2013-08-11 0:55 [PATCH 1/3] kbuild: Increase kallsyms max symbol length Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382459764.2041.90.camel@joe-AO722 \
--to=joe@perches.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jmario@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®