From: Joe Perches <joe@perches.com>
To: Sebastian Reichel <sre@debian.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Sachin Kamat <sachin.kamat@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCHv4 2/3] Input: twl4030-pwrbutton: use dev_err for errors
Date: Wed, 23 Oct 2013 12:38:14 -0700 [thread overview]
Message-ID: <1382557094.22433.40.camel@joe-AO722> (raw)
In-Reply-To: <20131023193112.GB30437@earth.universe>
On Wed, 2013-10-23 at 21:31 +0200, Sebastian Reichel wrote:
> On Wed, Oct 23, 2013 at 11:17:46AM -0700, Joe Perches wrote:
> > On Wed, 2013-10-23 at 19:54 +0200, Sebastian Reichel wrote:
> > > Use dev_err() to output errors instead of dev_dbg().
> > []
> > > diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> > []
> > > @@ -60,7 +60,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> > >
> > > pwr = input_allocate_device();
> > > if (!pwr) {
> > > - dev_dbg(&pdev->dev, "Can't allocate power button\n");
> > > + dev_err(&pdev->dev, "Can't allocate power button\n");
> > > return -ENOMEM;
> > > }
> >
> > input_allocate_device uses kzalloc and it will emit a
> > standardized OOM message along with a dump_stack()
> > so this dev_err/dev_dbg is redundant and not necessary.
>
> I saw you sent a big patchset changing this for all drivers.
> Should I drop this patch?
I think the 2 other bits of this patch are fine.
Maybe resend with this section dropped?
next prev parent reply other threads:[~2013-10-23 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 17:54 [PATCHv4 0/3] DT Support for TWL4030 power button Sebastian Reichel
2013-10-23 17:54 ` [PATCHv4 1/3] Input: twl4030-pwrbutton - add device tree support Sebastian Reichel
2013-10-24 7:47 ` Florian Vaussard
2013-10-24 8:38 ` Sebastian Reichel
2013-10-24 9:16 ` Florian Vaussard
2013-10-23 17:54 ` [PATCHv4 2/3] Input: twl4030-pwrbutton: use dev_err for errors Sebastian Reichel
2013-10-23 18:17 ` Joe Perches
2013-10-23 19:31 ` Sebastian Reichel
2013-10-23 19:38 ` Joe Perches [this message]
2013-10-23 17:54 ` [PATCHv4 3/3] Input: twl4030-pwrbutton: simplify driver using devm_* Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382557094.22433.40.camel@joe-AO722 \
--to=joe@perches.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rob.herring@calxeda.com \
--cc=sachin.kamat@linaro.org \
--cc=sre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®