From: Chuansheng Liu <chuansheng.liu@intel.com>
To: daniel.vetter@ffwll.ch, airlied@linux.ie
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
fei.li@intel.com
Subject: drm/i915: Avoid accessing the stolen address when it is unavailable
Date: Fri, 25 Oct 2013 00:33:47 +0800 [thread overview]
Message-ID: <1382632427.26153.94.camel@cliu38-desktop-build> (raw)
In our platform, we hit the the stolen region initialization failure case,
such as below log:
[drm:i915_stolen_to_physical] *ERROR* conflict detected with stolen region: [0x7b000000]
And it causes the dev_priv->mm.stolen_base is NULL, in this case, we should
avoid accessing it any more.
Here is possible call trace:
intel_enable_gt_powersave -- >
valleyview_enable_rps -- >
valleyview_setup_pctx
Cc: Li Fei <fei.li@intel.com>
Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 26c2ea3..1069b24 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3735,6 +3735,9 @@ static void valleyview_setup_pctx(struct drm_device *dev)
u32 pcbr;
int pctx_size = 24*1024;
+ if (!dev_priv->mm.stolen_base)
+ return;
+
pcbr = I915_READ(VLV_PCBR);
if (pcbr) {
/* BIOS set it up already, grab the pre-alloc'd space */
--
1.7.9.5
next reply other threads:[~2013-10-24 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 16:33 Chuansheng Liu [this message]
2013-10-24 12:17 ` Chris Wilson
2013-10-24 20:56 ` [Intel-gfx] " Ben Widawsky
2013-10-25 0:27 ` Liu, Chuansheng
2013-10-25 8:07 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382632427.26153.94.camel@cliu38-desktop-build \
--to=chuansheng.liu@intel.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fei.li@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®