From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen/hvc-console: Make it work with HVM guests.
Date: Thu, 24 Oct 2013 17:43:54 +0100 [thread overview]
Message-ID: <1382633034.22417.121.camel@hastur.hellion.org.uk> (raw)
In-Reply-To: <52694B3F.5090008@linaro.org>
On Thu, 2013-10-24 at 17:30 +0100, Julien Grall wrote:
> I'm sure the solution "move xen call earlier" will come up in few mails,
> so there was a discussion for swiotlb few weeks ago
> (https://lkml.org/lkml/2013/8/29/609). And the final decision was to
> avoid specific Xen call in arch_setup.
It wasn't so much a hard reject as a preference based on the need
presented at the time.
Perhaps a generic DT driven mechanism to detect hypervisors, called
early, would be more acceptable?
> Stefano, Ian, any opinion?
The ifdef approach is a bit ugly, but if the other option doesn't work
out I suppose we can live with it.
But stepping back how/why is this function called on x86 when not
running under Xen? Wouldn't the use have to be using console=hvc or
earlyprintk=xen or something -- which strikes me as user error... IOW
can we not just nuke the check
Ian.
next prev parent reply other threads:[~2013-10-24 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-27 21:25 Konrad Rzeszutek Wilk
2013-09-27 21:49 ` [Xen-devel] " Julien Grall
2013-09-30 14:45 ` Konrad Rzeszutek Wilk
2013-10-06 20:52 ` Julien Grall
2013-10-23 16:15 ` Konrad Rzeszutek Wilk
2013-10-23 22:08 ` Julien Grall
2013-10-24 14:49 ` Konrad Rzeszutek Wilk
2013-10-24 16:30 ` Julien Grall
2013-10-24 16:43 ` Ian Campbell [this message]
2013-10-25 19:38 ` Konrad Rzeszutek Wilk
2013-10-26 8:27 ` Ian Campbell
2013-10-28 15:48 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382633034.22417.121.camel@hastur.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®