Re: [PATCH] x86/ACPI: Make Sony Vaio Z1 series to use "reboot=pci" default

[Adam Williamson <awilliam@redhat.com>]

On Fri, 2013-10-25 at 12:53 +0200, Ingo Molnar wrote:
> * tianyu.lan@intel.com <tianyu.lan@intel.com> wrote:
> 
> > From: Lan Tianyu <tianyu.lan@intel.com>
> > 
> > Sony Vaio Z1 series require "reboot=pci" for reboot and power off.
> > This patch is to add them machines to quirk table and set pci reboot
> > default.
> > 
> > Reference: https://bugzilla.kernel.org/show_bug.cgi?id=61721
> > Reported-and-tested-by: Adam Williamson <awilliam@redhat.com>
> > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> > ---
> >  arch/x86/kernel/reboot.c |    8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> > index 7e920bf..083ade7 100644
> > --- a/arch/x86/kernel/reboot.c
> > +++ b/arch/x86/kernel/reboot.c
> > @@ -382,6 +382,14 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
> >  			DMI_MATCH(DMI_PRODUCT_NAME, "C6100"),
> >  		},
> >  	},
> > +	{	/* Handle problems with rebooting on Sony Vaio Z1 series*/
> > +		.callback = set_pci_reboot,
> > +		.ident = "Sony Vaio Z1",
> > +		.matches = {
> > +		DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
> > +		DMI_MATCH(DMI_PRODUCT_NAME, "VPCZ1"),
> > +		},
> > +	},
> 
> This is becoming somewhat endemic - do we know _why_ the ACPI reboot 
> method does not work?

I don't, but one comment I could add is that reboot _used_ to work okay
on the Z1. And I _think_ it's worked OK since the April 2011 commit you
mention (so the introduction of that didn't break it), but I can't
absolutely swear to it.

(And yes, of course, reboot from stock-installed, fully-updated Windows
- IIRC, Win7 - on the same system works OK.)
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net