From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
sachin.kamat@linaro.org, dan.j.williams@intel.com,
vinod.koul@intel.com,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: [PATCH 1/2] dma: mv_xor: Remove unneeded NULL address check
Date: Mon, 28 Oct 2013 19:54:14 -0300 [thread overview]
Message-ID: <1383000855-8377-1-git-send-email-ezequiel.garcia@free-electrons.com> (raw)
This mmio address is checked at probe-time, which makes this test
redundant. Let's just remove it.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
drivers/dma/mv_xor.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 536dcb8..d00d58e 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -1076,10 +1076,6 @@ mv_xor_channel_add(struct mv_xor_device *xordev,
}
mv_chan->mmr_base = xordev->xor_base;
- if (!mv_chan->mmr_base) {
- ret = -ENOMEM;
- goto err_free_dma;
- }
tasklet_init(&mv_chan->irq_tasklet, mv_xor_tasklet, (unsigned long)
mv_chan);
--
1.8.1.5
next reply other threads:[~2013-10-28 22:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 22:54 Ezequiel Garcia [this message]
2013-10-28 22:54 ` [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate Ezequiel Garcia
2013-10-28 23:47 ` Dan Williams
2013-10-29 8:34 ` Ezequiel Garcia
2013-10-29 9:32 ` Thomas Petazzoni
2013-10-29 19:15 ` Dan Williams
2013-10-29 19:24 ` Thomas Petazzoni
2013-10-30 0:33 ` Ezequiel Garcia
2013-10-30 0:40 ` Dan Williams
2013-10-29 9:31 ` [PATCH 1/2] dma: mv_xor: Remove unneeded NULL address check Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383000855-8377-1-git-send-email-ezequiel.garcia@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=dan.j.williams@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®