mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Yan, Zheng" <zheng.z.yan@intel.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	ak@linux.intel.com, eranian@google.com
Subject: Re: [PATCH 2/2] perf/x86/intel: Add Ivy Bridge-EP uncore IRP box support
Date: Wed, 30 Oct 2013 22:47:28 -0700	[thread overview]
Message-ID: <1383198448.24582.3.camel@joe-AO722> (raw)
In-Reply-To: <1383197815-17706-2-git-send-email-zheng.z.yan@intel.com>

On Thu, 2013-10-31 at 13:36 +0800, Yan, Zheng wrote:
> Unlike other uncore boxes, IRP boxes live in PCI buses with no UBOX
> device. For PCI bus without UBOX device, we find the next bus that
> has UBOX device and use its 'bus to socket' mapping.
[]
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
[]
> @@ -997,6 +997,20 @@ static int snbep_pci2phy_map_init(int devid)
[]
> +/* registers in IRP boxes are not properly aligned */
> +static unsigned ivt_uncore_irp_ctls[] = {0xd8, 0xdc, 0xe0, 0xe4};
> +static unsigned ivt_uncore_irp_ctrs[] = {0xa0, 0xb0, 0xb8, 0xc0};

Using this sort of naming is like asking for a typo
or a copy/paste defect.



  reply	other threads:[~2013-10-31  5:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-31  5:36 [PATCH 1/2] perf/x86/intel/uncore: Add filter support for IvyBridge-EP QPI boxes Yan, Zheng
2013-10-31  5:36 ` [PATCH 2/2] perf/x86/intel: Add Ivy Bridge-EP uncore IRP box support Yan, Zheng
2013-10-31  5:47   ` Joe Perches [this message]
2013-11-06 13:20   ` [tip:perf/core] " tip-bot for Yan, Zheng
2013-11-06 13:19 ` [tip:perf/core] perf/x86/intel/uncore: Add filter support for IvyBridge-EP QPI boxes tip-bot for Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383198448.24582.3.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=ak@linux.intel.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®