mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: [PATCHSET 0/5] perf tools: Enhance option parsing error message
Date: Fri,  1 Nov 2013 16:33:10 +0900	[thread overview]
Message-ID: <1383291195-24386-1-git-send-email-namhyung@kernel.org> (raw)

Hi,

This patchset tries to enhance error message when perf failed to parse
option argument.  Currently it just shows entire usage and options
which may fill two pages of screen.  It's hard for me to say it's
really helpful to users. ;-)

With this patch series, it changed to show only related option(s).
There're also more points to improve yet - like auto-breaking long
lines, dealing with UIs and so on.  But I believe this will be a good
start.

  $ perf report -g help

   usage: perf report [<options>]

      -g, --call-graph <output_type,min_percent[,print_limit],call_order>
                          Display callchains using output_type (graph, flat, fractal, or none) , min percent threshold, optional print limit, callchain order, key (function or address). Default: fractal,0.5,callee,function

  $ perf stat -Bx, ls
  -B option not supported with -x

   usage: perf stat [<options>] [<command>]

      -B, --big-num         print large numbers with thousands' separators
      -x, --field-separator <separator>
                            print counts with custom separator


You can get this on 'perf/option-v1' branch in my tree

  git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git


Thanks,
Namhyung


Namhyung Kim (5):
  perf tools: Show single option when failed to parse
  perf report: Postpone setting up browser after parsing options
  perf report: Use parse_options_usage() for -s option failure
  perf top: Use parse_options_usage() for -s option failure
  perf stat: Enhance option parse error message

 tools/perf/builtin-report.c     |  30 +++---
 tools/perf/builtin-stat.c       |  42 +++++---
 tools/perf/builtin-top.c        |   8 +-
 tools/perf/util/parse-options.c | 218 ++++++++++++++++++++++++----------------
 tools/perf/util/parse-options.h |   4 +-
 5 files changed, 181 insertions(+), 121 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2013-11-01  7:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01  7:33 Namhyung Kim [this message]
2013-11-01  7:33 ` [PATCH 1/5] perf tools: Show single option when failed to parse Namhyung Kim
2013-11-04 20:21   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-11-01  7:33 ` [PATCH 2/5] perf report: Postpone setting up browser after parsing options Namhyung Kim
2013-11-04 20:21   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-11-01  7:33 ` [PATCH 3/5] perf report: Use parse_options_usage() for -s option failure Namhyung Kim
2013-11-04 20:21   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-11-01  7:33 ` [PATCH 4/5] perf top: " Namhyung Kim
2013-11-04 20:22   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-11-01  7:33 ` [PATCH 5/5] perf stat: Enhance option parse error message Namhyung Kim
2013-11-04 20:22   ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-11-01  7:38 ` [PATCHSET 0/5] perf tools: Enhance option parsing " Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383291195-24386-1-git-send-email-namhyung@kernel.org \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®