From: Peter Huewe <peterhuewe@gmx.de>
To: james.l.morris@oracle.com, tpmdd-devel@lists.sourceforge.net,
adlai@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH 5/6] tpm/tpm_i2c_atmel: fix coccinelle warnings
Date: Sat, 2 Nov 2013 18:25:00 +0100 [thread overview]
Message-ID: <1383413101-10975-5-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <1383413101-10975-1-git-send-email-peterhuewe@gmx.de>
From: Fengguang Wu <fengguang.wu@intel.com>
drivers/char/tpm/tpm_i2c_atmel.c:178:8-9: WARNING: return of 0/1 in function 'i2c_atmel_req_canceled' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: coccinelle/misc/boolreturn.cocci
CC: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
CC: Peter Huewe <peterhuewe@gmx.de>
Acked-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/char/tpm/tpm_i2c_atmel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index c3cd7fe..af6805b 100644
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -175,7 +175,7 @@ static struct attribute_group i2c_atmel_attr_grp = {
static bool i2c_atmel_req_canceled(struct tpm_chip *chip, u8 status)
{
- return 0;
+ return false;
}
static const struct tpm_vendor_specific i2c_atmel = {
--
1.7.5.4
next prev parent reply other threads:[~2013-11-02 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <trinity-0ea948ed-45da-4711-91da-0d251d630d89-1383412993117@3capp-gmx-bs02>
2013-11-02 17:24 ` [PATCH 1/6] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1 Peter Huewe
2013-11-02 17:24 ` [PATCH 2/6] tpm/tpm_ppi: Check return value of acpi_get_name Peter Huewe
2013-11-02 17:24 ` [PATCH 3/6] tpm/tpm_i2c_stm_st33: Check return code of get_burstcount Peter Huewe
2013-11-02 17:24 ` [PATCH 4/6] tpm/tpm_ibmvtpm: fix unreachable code warning (smatch warning) Peter Huewe
2013-11-02 17:25 ` Peter Huewe [this message]
2013-11-02 17:25 ` [PATCH 6/6] tpm: MAINTAINERS: Cleanup TPM Maintainers file Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383413101-10975-5-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=adlai@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®