mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "Peter Hüwe" <PeterHuewe@gmx.de>,
	"Ashley Lai" <ashley@ashleylai.com>,
	"Rajiv Andrade" <mail@srajiv.net>,
	"Marcel Selhorst" <tpmdd@selhorst.net>,
	tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] tpm/tpm_i2c_stm_st33: Check return code of get_burstcount (fix CID: 986658)
Date: Mon, 04 Nov 2013 03:44:48 +0000	[thread overview]
Message-ID: <1383536688.2764.59.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20131030030747.GA12179@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On Tue, 2013-10-29 at 20:07 -0700, Greg KH wrote:
> On Wed, Oct 30, 2013 at 01:42:11AM +0100, Peter Hüwe wrote:
> > Hi Greg,
> > > > 
> > > > CID: 986658
> > > What is this field for?
> > 
> > That's the scan id in the coverity database.
> > If you think that's just noise I can leave it out.
> 
> It's noise as not everyone can see it or make anything out of it, so
> please don't include it.

I think it's useful information for people who became aware of the bug
via Coverity.  It's not so different from a CVE ID, or a reference to
one of the various enterprise distro bug trackers where bug reports
often aren't public.

Obviously this cannot be a substitute for explaining the bug properly in
the commit message.

Ben.

-- 
Ben Hutchings
Kids!  Bringing about Armageddon can be dangerous.  Do not attempt it in
your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      parent reply	other threads:[~2013-11-04  3:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 23:54 Peter Huewe
2013-10-30  0:06 ` Greg KH
2013-10-30  0:42   ` Peter Hüwe
2013-10-30  3:07     ` Greg KH
2013-10-30 19:38       ` Peter Hüwe
2013-11-04  3:44       ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383536688.2764.59.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=PeterHuewe@gmx.de \
    --cc=ashley@ashleylai.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@srajiv.net \
    --cc=stable@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®