mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Haverkamp <haver@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
	cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
	utz.bacher@de.ibm.com, mmarek@suse.cz, rmallon@gmail.com,
	jsvogt@de.ibm.com, MIJUNG@de.ibm.com,
	cascardo@linux.vnet.ibm.com, michael@ibmra.de,
	haver@linux.vnet.ibm.com
Subject: [PATCH 5/9] GenWQE: Move comments
Date: Mon,  4 Nov 2013 18:08:05 +0100	[thread overview]
Message-ID: <1383584889-21594-6-git-send-email-haver@linux.vnet.ibm.com> (raw)
In-Reply-To: <1383584889-21594-1-git-send-email-haver@linux.vnet.ibm.com>

Move documentation from driver sources to appropriate place in the
sysfs documentation file for this driver

Signed-off-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
---
 Documentation/ABI/testing/sysfs-driver-genwqe |    9 +++++++++
 drivers/misc/genwqe/card_base.c               |   20 --------------------
 2 files changed, 9 insertions(+), 20 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-genwqe b/Documentation/ABI/testing/sysfs-driver-genwqe
index d85c076..0976901 100644
--- a/Documentation/ABI/testing/sysfs-driver-genwqe
+++ b/Documentation/ABI/testing/sysfs-driver-genwqe
@@ -44,3 +44,12 @@ What:           /sys/class/genwqe/genwqe<n>_card/base_clock
 Date:           Oct 2013
 Contact:        haver@linux.vnet.ibm.com
 Description:    Base clock frequency of the card.
+
+What:           /sys/class/genwqe/genwqe<n>_card/device/sriov_numvfs
+Date:           Oct 2013
+Contact:        haver@linux.vnet.ibm.com
+Description:    Enable VFs (1..15):
+                  sudo sh -c 'echo 15 > \
+                    /sys/bus/pci/devices/0000\:1b\:00.0/sriov_numvfs'
+                Disable VFs:
+                  Write a 0 into the same sysfs entry.
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
index 271d957..c649ef7 100644
--- a/drivers/misc/genwqe/card_base.c
+++ b/drivers/misc/genwqe/card_base.c
@@ -22,16 +22,6 @@
  * Module initialization and PCIe setup. Card health monitoring and
  * recovery functionality. Character device creation and deletion are
  * controlled from here.
- *
- * Please use the new sysfs interfaces to enable the VFs after PF
- * driver loading.
- *
- * Enable VFs:
- *   sudo sh -c 'echo 15 > /sys/bus/pci/devices/0000\:1b\:00.0/sriov_numvfs'
- * or
- *   sudo sh -c 'echo 15 > /sys/class/genwqe/genwqe0_card/device/sriov_numvfs'
- * Disable VFs:
- *   Write a 0 into the same sysfs entries.
  */
 
 #include <linux/module.h>
@@ -798,22 +788,12 @@ static u64 genwqe_fir_checking(struct genwqe_dev *cd)
  *
  * This thread must only exit if kthread_should_stop() becomes true.
  *
- * Testing bind/unbind with:
- *   sudo sh -c "echo -n 0000:20:00.0 > /sys/bus/pci/drivers/genwqe/unbind"
- *   sudo sh -c "echo -n 0000:20:00.0 > /sys/bus/pci/drivers/genwqe/bind"
- *
  * Condition for the health-thread to trigger:
  *   a) when a kthread_stop() request comes in or
  *   b) a critical GFIR occured
  *
  * Informational GFIRs are checked and potentially printed in
  * health_check_interval seconds.
- *
- * Testcase to trigger this code:
- *   Fatal GFIR:
- *     sudo ./tools/genwqe_poke -C0 0x00000008 0x001
- *   Info GFIR by writing to VF:
- *     sudo ./tools/genwqe_poke -C2 0x00020020 0x800
  */
 static int genwqe_health_thread(void *data)
 {
-- 
1.7.1


  parent reply	other threads:[~2013-11-04 17:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-04 17:08 [PATCH 0/9] Generic WorkQueue Engine (GenWQE) device driver (v5) Frank Haverkamp
2013-11-04 17:08 ` [PATCH 1/9] Generic WorkQueue Engine (GenWQE) device driver (v4) Frank Haverkamp
2013-11-04 22:12   ` Greg KH
2013-11-05  7:21     ` Frank Haverkamp
2013-11-04 17:08 ` [PATCH 2/9] GenWQE: Remove option to select name Frank Haverkamp
2013-11-04 21:55   ` Ryan Mallon
2013-11-05  9:00     ` Frank Haverkamp
2013-11-04 17:08 ` [PATCH 3/9] GenWQE: Remove obsolete constants Frank Haverkamp
2013-11-04 17:08 ` [PATCH 4/9] GenWQE: Rework comments Frank Haverkamp
2013-11-04 17:08 ` Frank Haverkamp [this message]
2013-11-04 17:08 ` [PATCH 6/9] GenWQE: Remove/rework module parameters Frank Haverkamp
2013-11-04 17:08 ` [PATCH 7/9] GenWQE: Start using sysfs attribute groups Frank Haverkamp
2013-11-04 17:08 ` [PATCH 8/9] GenWQE: Simplify sysfs buffer printouts Frank Haverkamp
2013-11-04 17:08 ` [PATCH 9/9] GenWQE: Increment driver internal version number Frank Haverkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383584889-21594-6-git-send-email-haver@linux.vnet.ibm.com \
    --to=haver@linux.vnet.ibm.com \
    --cc=MIJUNG@de.ibm.com \
    --cc=arnd@arndb.de \
    --cc=cascardo@linux.vnet.ibm.com \
    --cc=cody@linux.vnet.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jsvogt@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@ibmra.de \
    --cc=mmarek@suse.cz \
    --cc=rmallon@gmail.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®