From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569Ab3KFT2V (ORCPT ); Wed, 6 Nov 2013 14:28:21 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:63815 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755164Ab3KFT2U (ORCPT ); Wed, 6 Nov 2013 14:28:20 -0500 Message-ID: <1383766098.21999.2.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH] net: don't forget to free sk_filter From: Eric Dumazet To: Daniel Borkmann Cc: Andrey Vagin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Eric Dumazet , "David S. Miller" , stable@vger.kernel.org.#.3.12 Date: Wed, 06 Nov 2013 11:28:18 -0800 In-Reply-To: <527A9638.4020404@redhat.com> References: <1383753106-26978-1-git-send-email-avagin@openvz.org> <527A9638.4020404@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-11-06 at 20:19 +0100, Daniel Borkmann wrote: > When you send v2 with Alexei's feedback, please also be more specific > in your subject like "net: x86: bpf: don't forget to free sk_filter" > or the like. Also it's enough to say 'This memory leak was introduced > by commit d45ed4a4e3 ("net: fix unsafe set_memory_rw from softirq")' > instead of copying the whole log. Anyways, for v2 with feedback included > then: Actually, the new way [1] of doing this would be to use the 'Fixes:' tag as in : Fixes: <12 digits SHA1> ("net: fix unsafe set_memory_rw from softirq") [1] As discussed at last Kernel Summit Example in http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=6920a1bd037374a632d585de127b6f945199dcb8