mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [trivial PATCH] module.h: Remove unnecessary semicolon
Date: Thu, 07 Nov 2013 15:59:37 -0800	[thread overview]
Message-ID: <1383868777.9263.39.camel@joe-AO722> (raw)
In-Reply-To: <877gcj6c3v.fsf@rustcorp.com.au>

On Fri, 2013-11-08 at 09:41 +1030, Rusty Russell wrote:
> Joe Perches <joe@perches.com> writes:
> > On Thu, 2013-11-07 at 12:32 +1030, Rusty Russell wrote:
> >> Joe Perches <joe@perches.com> writes:
> >> > This semicolon isn't necessary, remove it.
> >> >
> >> > Signed-off-by: Joe Perches <joe@perches.com>
> >> 
> >> This is a terrible description.  Really bad.
> >
> > I'd've preferred no description.
> 
> Me too.
> 
> >> First, it just repeats the subject, with more words.
> >
> > Which others have demanded.
> 
> They're wrong.

shrug.  Can't please everyone.

> >> Second, it gives me no indication that you've done a grep to make sure
> >> noone is abusing the macro, so I can't apply it without doing that check
> >> myself.
> >
> > That's a trust issue.
> > I've done it.  It isn't necessary.
> 
> WTF?  Now you just said it's not necessary, I *know* I can't trust you.

"It" in this case is the grep that I did
prior to sending the patch.

> > The other #define module_put_and_exit in a
> > different #if #else already doesn't have one.
> 
> You didn't mention this, and even if you did, it's not sufficient.  Some
> code only ever gets compiled as a module, so it'd never hit the
> !CONFIG_MODULES case.

Which would only show there was a latent bug.

> > Trust it or not, apply it or not.
> 
> Now I know when I receive a patch from you I have to check it carefully,
> because you can't be bothered.

Sure.  If you think so.
Nonetheless, I told you I'd checked it.

> I've fixed your patch, you can find it below.

No, not really fixed.  You modified the commit log to
suit your taste.

cheers, Joe



  reply	other threads:[~2013-11-07 23:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-05 20:58 Joe Perches
2013-11-07  2:02 ` Rusty Russell
2013-11-07  5:09   ` Joe Perches
2013-11-07 23:11     ` Rusty Russell
2013-11-07 23:59       ` Joe Perches [this message]
2013-11-08  1:26         ` Rusty Russell
2013-11-08  1:48           ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383868777.9263.39.camel@joe-AO722 \
    --to=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®