From: Felipe Contreras <felipe.contreras@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH 2/3] panic: improve panic_timeout calculation
Date: Thu, 7 Nov 2013 18:46:39 -0600 [thread overview]
Message-ID: <1383871600-3831-3-git-send-email-felipe.contreras@gmail.com> (raw)
In-Reply-To: <1383871600-3831-1-git-send-email-felipe.contreras@gmail.com>
We want to calculate the blinks per second, and instead of making it 5
(1000 / (3600 / 18)), let's make it 4, so the user can see two blinks
per second.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
kernel/panic.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index 46e37ff..5a0bdaa 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -25,7 +25,7 @@
#include <linux/nmi.h>
#define PANIC_TIMER_STEP 100
-#define PANIC_BLINK_SPD 18
+#define PANIC_BLINK_SPD 4
int panic_on_oops = CONFIG_PANIC_ON_OOPS_VALUE;
static unsigned long tainted_mask;
@@ -147,7 +147,7 @@ void panic(const char *fmt, ...)
touch_nmi_watchdog();
if (i >= i_next) {
i += panic_blink(state ^= 1);
- i_next = i + 3600 / PANIC_BLINK_SPD;
+ i_next = i + 1000 / PANIC_BLINK_SPD;
}
mdelay(PANIC_TIMER_STEP);
}
@@ -181,7 +181,7 @@ void panic(const char *fmt, ...)
touch_softlockup_watchdog();
if (i >= i_next) {
i += panic_blink(state ^= 1);
- i_next = i + 3600 / PANIC_BLINK_SPD;
+ i_next = i + 1000 / PANIC_BLINK_SPD;
}
mdelay(PANIC_TIMER_STEP);
}
--
1.8.4.2+fc1
next prev parent reply other threads:[~2013-11-08 0:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-08 0:46 [PATCH 0/3] panic: improvements Felipe Contreras
2013-11-08 0:46 ` [PATCH 1/3] panic: setup panic_timeout early Felipe Contreras
2013-11-11 13:44 ` Ingo Molnar
2013-11-11 14:17 ` Felipe Contreras
2013-11-11 14:22 ` Ingo Molnar
2013-11-11 14:45 ` Felipe Contreras
2013-11-08 0:46 ` Felipe Contreras [this message]
2013-11-11 11:32 ` [PATCH 2/3] panic: improve panic_timeout calculation Ingo Molnar
2013-11-11 12:44 ` Felipe Contreras
2013-11-11 12:49 ` Ingo Molnar
2013-11-11 12:54 ` Felipe Contreras
2013-11-11 13:28 ` Ingo Molnar
2013-11-11 13:43 ` Felipe Contreras
2013-11-11 13:52 ` Ingo Molnar
2013-11-11 15:32 ` Theodore Ts'o
2013-11-11 15:59 ` Felipe Contreras
2013-11-13 0:06 ` Ingo Molnar
2013-11-08 0:46 ` [PATCH 3/3] panic: enable local IRQs for restart timeout too Felipe Contreras
2013-11-11 13:19 ` Ingo Molnar
2013-11-11 13:30 ` Felipe Contreras
2013-11-11 13:54 ` Ingo Molnar
2013-11-11 14:40 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383871600-3831-3-git-send-email-felipe.contreras@gmail.com \
--to=felipe.contreras@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®