From: Ian Campbell <Ian.Campbell@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: <xen-devel@lists.xensource.com>, <linux-kernel@vger.kernel.org>,
<konrad.wilk@oracle.com>
Subject: Re: [PATCH] xen/arm: pfn_to_mfn and mfn_to_pfn return the argument if nothing is in the p2m
Date: Mon, 11 Nov 2013 13:03:47 +0000 [thread overview]
Message-ID: <1384175027.19117.15.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <1384174231-27176-1-git-send-email-stefano.stabellini@eu.citrix.com>
On Mon, 2013-11-11 at 12:50 +0000, Stefano Stabellini wrote:
> Some common Xen drivers, like balloon.c, call pfn_to_mfn and mfn_to_pfn
> even for autotranslate guests, expecting the argument back.
> The following commit broke these drivers by changing the behavior of
> pfn_to_mfn and mfn_to_pfn:
>
> commit 4a19138c6505e224d9f4cc2fe9ada9188d7100ea
> Author: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Date: Thu Oct 17 16:22:27 2013 +0000
>
> arm/xen,arm64/xen: introduce p2m
>
> They now return INVALID_P2M_ENTRY if Linux doesn't actually know what is
> the mfn backing a pfn or what is the pfn corresponding to an mfn.
> Fix the regression by switching to the old behavior.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I tripped over this on Friday and my local hack was identical, hence
also:
Tested-by: Ian Campbell <ian.campbell@citrix.com>
Ian.
prev parent reply other threads:[~2013-11-11 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 12:50 Stefano Stabellini
2013-11-11 13:03 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384175027.19117.15.camel@kazak.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®