From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: alexander.shishkin@linux.intel.com
Cc: gregkh@linuxfoundation.org, rob.herring@calxeda.com,
pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, davidb@codeaurora.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state
Date: Mon, 11 Nov 2013 15:35:37 +0200 [thread overview]
Message-ID: <1384176937-1658-5-git-send-email-iivanov@mm-sol.com> (raw)
In-Reply-To: <1384176937-1658-1-git-send-email-iivanov@mm-sol.com>
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
PHY drivers keep track of the current state of the hardware,
so don't change PHY settings under it.
Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
---
drivers/usb/chipidea/ci_hdrc_msm.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index e9624f3..338b209 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -20,13 +20,11 @@
static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
{
struct device *dev = ci->gadget.dev.parent;
- int val;
switch (event) {
case CI_HDRC_CONTROLLER_RESET_EVENT:
dev_dbg(dev, "CI_HDRC_CONTROLLER_RESET_EVENT received\n");
- writel(0, USB_AHBBURST);
- writel(0, USB_AHBMODE);
+ usb_phy_init(ci->transceiver);
break;
case CI_HDRC_CONTROLLER_STOPPED_EVENT:
dev_dbg(dev, "CI_HDRC_CONTROLLER_STOPPED_EVENT received\n");
@@ -34,10 +32,7 @@ static void ci_hdrc_msm_notify_event(struct ci_hdrc *ci, unsigned event)
* Put the transceiver in non-driving mode. Otherwise host
* may not detect soft-disconnection.
*/
- val = usb_phy_io_read(ci->transceiver, ULPI_FUNC_CTRL);
- val &= ~ULPI_FUNC_CTRL_OPMODE_MASK;
- val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING;
- usb_phy_io_write(ci->transceiver, val, ULPI_FUNC_CTRL);
+ usb_phy_notify_disconnect(ci->transceiver, USB_SPEED_UNKNOWN);
break;
default:
dev_dbg(dev, "unknown ci_hdrc event\n");
--
1.7.9.5
next prev parent reply other threads:[~2013-11-11 13:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 13:35 [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver Ivan T. Ivanov
2013-11-11 13:35 ` [PATCH 1/4] usb: chipidea: msm: Add device tree binding information Ivan T. Ivanov
2013-12-04 5:40 ` Peter Chen
2013-12-04 8:33 ` Ivan T. Ivanov
2013-12-04 13:13 ` Peter Chen
2013-11-11 13:35 ` [PATCH 2/4] usb: chipidea: msm: Add device tree support Ivan T. Ivanov
2013-11-11 13:35 ` [PATCH 3/4] usb: chipidea: msm: Initialize offset of the capability registers Ivan T. Ivanov
2013-12-04 5:43 ` Peter Chen
2013-12-04 9:07 ` Ivan T. Ivanov
2013-11-11 13:35 ` Ivan T. Ivanov [this message]
2013-11-11 13:59 ` [PATCH 4/4] usb: chipidea: msm: Use USB PHY API to control PHY state Peter Chen
2013-11-11 14:36 ` Ivan T. Ivanov
2013-12-04 5:37 ` Peter Chen
2013-12-04 9:35 ` Ivan T. Ivanov
2013-12-04 13:38 ` Peter Chen
2013-12-11 10:26 ` Ivan T. Ivanov
2013-11-11 14:02 ` [PATCH 0/4] usb: chipidea: msm: Clean and fix glue layer driver Peter Chen
2013-11-11 14:49 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384176937-1658-5-git-send-email-iivanov@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidb@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®