mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: linux-kernel@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Joe Mario <jmario@redhat.com>
Subject: [PATCH 2/2] kallsyms: Revert back to 128 max symbol length
Date: Mon, 11 Nov 2013 14:40:36 +0100	[thread overview]
Message-ID: <1384177236-8371-2-git-send-email-mmarek@suse.cz> (raw)
In-Reply-To: <1384177236-8371-1-git-send-email-mmarek@suse.cz>

This reverts commits
f3462aa (Kbuild: Handle longer symbols in kallsyms.c) and
eea0e9c (kbuild: Increase kallsyms max symbol length)
except for the added overflow check. The reason is a regression caused
by increasing the buffer:
http://marc.info/?l=linux-kernel&m=138387700415675.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Joe Mario <jmario@redhat.com>
Signed-off-by: Michal Marek <mmarek@suse.cz>
---
 include/linux/kallsyms.h | 2 +-
 scripts/kallsyms.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
index 5648870..6883e19 100644
--- a/include/linux/kallsyms.h
+++ b/include/linux/kallsyms.h
@@ -9,7 +9,7 @@
 #include <linux/kernel.h>
 #include <linux/stddef.h>
 
-#define KSYM_NAME_LEN 255
+#define KSYM_NAME_LEN 128
 #define KSYM_SYMBOL_LEN (sizeof("%s+%#lx/%#lx [%s]") + (KSYM_NAME_LEN - 1) + \
 			 2*(BITS_PER_LONG*3/10) + (MODULE_NAME_LEN - 1) + 1)
 
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 48afa20..518da86c 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -27,7 +27,7 @@
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0]))
 #endif
 
-#define KSYM_NAME_LEN		255
+#define KSYM_NAME_LEN		128
 
 struct sym_entry {
 	unsigned long long addr;
-- 
1.8.1.4


  reply	other threads:[~2013-11-11 13:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 13:40 [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names Michal Marek
2013-11-11 13:40 ` Michal Marek [this message]
2013-11-11 14:17   ` [PATCH 2/2] kallsyms: Revert back to 128 max symbol length Andi Kleen
2013-11-11 17:02     ` Michal Marek
2013-11-12 21:55     ` Joe Mario
2013-11-13 15:12       ` Michal Marek
2013-11-12  8:40 ` [PATCH 1/2] PCI: Do not use PCI ID macros in quirk names Michal Marek
2013-11-25 22:18   ` Bjorn Helgaas
2013-11-25 23:02     ` Andi Kleen
2013-11-25 23:06 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384177236-8371-2-git-send-email-mmarek@suse.cz \
    --to=mmarek@suse.cz \
    --cc=ak@linux.intel.com \
    --cc=jmario@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®