From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@linuxfoundation.org
Cc: jirislaby@gmail.com, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>
Subject: [PATCH 1/1] TTY: tty_buffer, warn on leaks
Date: Mon, 11 Nov 2013 21:05:59 +0100 [thread overview]
Message-ID: <1384200359-31356-1-git-send-email-jslaby@suse.cz> (raw)
When we leak something, warn about that. For that we need to account
the memory used also in the free_all method. It is handled elsewhere
correctly.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/tty/tty_buffer.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index 5f08c39e76ab..20cb9492dbf8 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -115,21 +115,27 @@ void tty_buffer_free_all(struct tty_port *port)
struct tty_bufhead *buf = &port->buf;
struct tty_buffer *p, *next;
struct llist_node *llist;
+ int zero = 0;
while ((p = buf->head) != NULL) {
buf->head = p->next;
+ atomic_sub(p->size, &buf->memory_used);
if (p->size > 0)
kfree(p);
}
llist = llist_del_all(&buf->free);
- llist_for_each_entry_safe(p, next, llist, free)
+ llist_for_each_entry_safe(p, next, llist, free) {
+ atomic_sub(p->size, &buf->memory_used);
kfree(p);
+ }
+
tty_buffer_reset(&buf->sentinel, 0);
buf->head = &buf->sentinel;
buf->tail = &buf->sentinel;
- atomic_set(&buf->memory_used, 0);
+ atomic_xchg(&buf->memory_used, zero);
+ WARN_ON(zero != 0);
}
/**
--
1.8.4.2
next reply other threads:[~2013-11-11 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 20:05 Jiri Slaby [this message]
2013-11-11 23:13 ` Peter Hurley
2013-11-27 1:13 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384200359-31356-1-git-send-email-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®