From: Jerry Hoemann <jerry.hoemann@hp.com>
To: rob@landley.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, matt.fleming@intel.com,
yinghai@kernel.org, penberg@kernel.org,
akpm@linux-foundation.org, linux-doc@vger.kernel.org,
linux-efi@vger.kernel.org, vgoyal@redhat.com
Cc: linux-kernel@vger.kernel.org, jerry.hoemann@hp.com
Subject: [PATCH 2/3] x86: avoid efi_reserve_boot_services
Date: Mon, 11 Nov 2013 19:15:57 -0700 [thread overview]
Message-ID: <1384222558-38527-3-git-send-email-jerry.hoemann@hp.com> (raw)
In-Reply-To: <1384222558-38527-1-git-send-email-jerry.hoemann@hp.com>
Some platform have firmware that violate UEFI spec and access boot service
code or data segments after the system has called Exit Boot Services.
The call to efi_reserve_boot_services is a work around to avoid using
boot service memory until after the kernel has done Set Virtual Map.
However, this reservation fragments memory which can cause
large allocations early in boot (e.g. crash kernel) to fail.
Avoid calling efi_reserve_boot_services if the memmap
is "correct."
Signed-off-by: Jerry Hoemann <jerry.hoemann@hp.com>
---
arch/x86/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index f0de629..1186ff9 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1074,7 +1074,7 @@ void __init setup_arch(char **cmdline_p)
* The EFI specification says that boot service code won't be called
* after ExitBootServices(). This is, in fact, a lie.
*/
- if (efi_enabled(EFI_MEMMAP))
+ if (efi_enabled(EFI_MEMMAP) && !efi_enabled(EFI_MEMMAP_CORRECT))
efi_reserve_boot_services();
/* preallocate 4k for mptable mpc */
--
1.7.11.3
next prev parent reply other threads:[~2013-11-12 2:16 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 2:15 [PATCH 0/3] Early use of boot service memory Jerry Hoemann
2013-11-12 2:15 ` [PATCH 1/3] efi: " Jerry Hoemann
2013-11-12 2:15 ` Jerry Hoemann [this message]
2013-11-12 2:15 ` [PATCH 3/3] x86, " Jerry Hoemann
2013-11-12 10:37 ` [PATCH 0/3] " Pekka Enberg
2013-11-12 17:55 ` jerry.hoemann
2013-11-12 18:48 ` Pekka Enberg
2013-11-12 21:52 ` jerry.hoemann
2013-11-12 18:58 ` H. Peter Anvin
2013-11-13 22:45 ` jerry.hoemann
2013-11-13 22:49 ` H. Peter Anvin
2013-11-13 23:57 ` jerry.hoemann
2013-11-14 0:05 ` H. Peter Anvin
2013-11-14 1:40 ` jerry.hoemann
2014-08-01 9:54 ` Yuhong Bao
2013-11-14 8:24 ` Pekka Enberg
2013-11-14 18:04 ` jerry.hoemann
2013-11-14 18:44 ` Pekka Enberg
2013-11-14 18:45 ` H. Peter Anvin
2013-11-15 0:50 ` jerry.hoemann
2013-11-15 6:24 ` Ingo Molnar
2013-11-15 6:55 ` Yinghai Lu
2013-11-15 6:59 ` H. Peter Anvin
2013-11-15 14:07 ` Vivek Goyal
2013-11-15 17:33 ` Yinghai Lu
2013-11-15 17:40 ` H. Peter Anvin
2013-11-15 18:30 ` Vivek Goyal
2013-11-15 18:46 ` H. Peter Anvin
2013-11-15 19:16 ` H. Peter Anvin
2013-11-18 15:22 ` Vivek Goyal
2013-11-18 18:29 ` H. Peter Anvin
2013-11-18 18:52 ` Vivek Goyal
2013-11-19 1:32 ` H. Peter Anvin
2013-11-19 3:02 ` Yinghai Lu
2013-11-15 18:03 ` Vivek Goyal
2013-11-15 22:24 ` Yinghai Lu
2013-11-15 22:55 ` jerry.hoemann
2013-11-15 23:43 ` Yinghai Lu
2013-11-18 15:32 ` Vivek Goyal
2013-11-18 19:34 ` Yinghai Lu
2013-11-18 19:39 ` Vivek Goyal
2013-11-15 18:16 ` jerry.hoemann
2013-11-15 19:13 ` jerry.hoemann
2013-11-18 15:42 ` Vivek Goyal
2013-11-15 8:36 ` Pekka Enberg
2013-11-14 15:26 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384222558-38527-3-git-send-email-jerry.hoemann@hp.com \
--to=jerry.hoemann@hp.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=penberg@kernel.org \
--cc=rob@landley.net \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®