From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, mina86@mina86.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH v6 5/5] usb: dwc3: implement gadget's quirk ep_out_align_size
Date: Tue, 12 Nov 2013 13:04:46 -0800 [thread overview]
Message-ID: <1384290286-21432-6-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1384290286-21432-1-git-send-email-david.a.cohen@linux.intel.com>
DWC3 requires epout to have buffer size aligned to MaxPacketSize value.
This patch implements necessary quirk for it.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---
drivers/usb/dwc3/core.h | 6 ++++++
drivers/usb/dwc3/gadget.c | 23 +++++++++++++++++++++++
2 files changed, 29 insertions(+)
diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index f8af8d44af85..ff42d7ddc546 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -571,6 +571,12 @@ struct dwc3_request {
struct dwc3_ep *dep;
u32 start_slot;
+ /*
+ * If gadget/epout, we need to pad buffer size to align with
+ * maxpacketsize.
+ */
+ size_t pad;
+
u8 epnum;
struct dwc3_trb *trb;
dma_addr_t trb_dma;
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5452c0fce360..7c2d36f6ad4b 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1130,6 +1130,14 @@ static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,
dev_vdbg(dwc->dev, "queing request %p to %s length %d\n",
request, ep->name, request->length);
+ /* If ep out, roundup request->length to epout maxpacketsize */
+ if (!(dep->number & 1)) {
+ unsigned int aligned = roundup(request->length,
+ ep->desc->wMaxPacketSize);
+ req->pad = aligned - request->length;
+ request->length = aligned;
+ }
+
spin_lock_irqsave(&dwc->lock, flags);
ret = __dwc3_gadget_ep_queue(dep, req);
spin_unlock_irqrestore(&dwc->lock, flags);
@@ -1173,6 +1181,15 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
}
out1:
+ if (!(dep->number & 1)) {
+ /*
+ * Sanitize request->length after pad was applied before
+ * queue.
+ */
+ request->length -= req->pad;
+ req->pad = 0;
+ }
+
/* giveback the request */
dwc3_gadget_giveback(dep, req, -ECONNRESET);
@@ -2600,6 +2617,12 @@ int dwc3_gadget_init(struct dwc3 *dwc)
dwc->gadget.name = "dwc3-gadget";
/*
+ * Per databook, DWC3 needs buffer size to be aligned to MaxPacketSize
+ * on ep out.
+ */
+ dwc->gadget.quirk_ep_out_aligned_size = true;
+
+ /*
* REVISIT: Here we should clear all pending IRQs to be
* sure we're starting from a well known location.
*/
--
1.8.4.2
next prev parent reply other threads:[~2013-11-12 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 21:04 [PATCH v6 0/5] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-11-12 21:04 ` [PATCH v6 1/5] usb: gadget: move bitflags to the end of usb_gadget struct David Cohen
2013-11-12 21:04 ` [PATCH v6 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-11-12 21:04 ` [PATCH v6 3/5] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-11-12 21:04 ` [PATCH v6 4/5] check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-11-12 21:04 ` David Cohen [this message]
2013-11-25 21:06 ` [PATCH v6 5/5] usb: dwc3: implement gadget's quirk ep_out_align_size Felipe Balbi
2013-12-02 18:31 ` David Cohen
2013-12-03 22:16 ` David Cohen
2013-11-12 21:05 ` [PATCH v6 0/5] add gadget quirk to adapt f_fs for DWC3 David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384290286-21432-6-git-send-email-david.a.cohen@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome