From: Joe Perches <joe@perches.com>
To: Marek Vasut <marex@denx.de>
Cc: Andreas Werner <wernerandy@gmx.de>,
wsa@the-dreams.de, jacmet@sunsite.dk, baohua.song@csr.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I2C: busses: Do not print error message in syslog if no ACK received
Date: Thu, 14 Nov 2013 05:39:52 -0800 [thread overview]
Message-ID: <1384436392.15774.2.camel@joe-AO722> (raw)
In-Reply-To: <201311132024.06853.marex@denx.de>
On Wed, 2013-11-13 at 20:24 +0100, Marek Vasut wrote:
> > On Tue, Nov 12, 2013 at 07:33:40PM +0100, Marek Vasut wrote:
> > > > > That is because if you look at the only caller of this function,
> > > > > which is pch_i2c_wait_for_check_xfer(), you will see that at the
> > > > > only place where pch_i2c_getack() is called there is already
> > > > > pch_dbg():
> > > > >
> > > > > 369 if (pch_i2c_getack(adap)) {
> > > > > 370 pch_dbg(adap, "Receive NACK for slave address"
> > > > > 371 "setting\n");
> > > > > 372 return -EIO;
> > > > > 373 }
> >
> > Sorry i misunderstood that. You are absolutly right, thats the best
> > solution for that. Remove the pch_err at getack so that only the pch_dbg
> > get printed where getack is called. This should be enough information.
>
> No problem ;-)
If this is the approach taken, please coalesce the format.
As is there's a missing space between address and setting.
This should be:
pch_dbg(adap, "Received NACK for slave address setting\n");
next prev parent reply other threads:[~2013-11-14 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 17:45 Andreas Werner
2013-11-12 18:00 ` Marek Vasut
2013-11-12 18:23 ` Andreas Werner
2013-11-12 18:33 ` Marek Vasut
2013-11-13 18:24 ` Andreas Werner
2013-11-13 19:24 ` Marek Vasut
2013-11-14 13:39 ` Joe Perches [this message]
2013-11-14 18:26 ` Andreas Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384436392.15774.2.camel@joe-AO722 \
--to=joe@perches.com \
--cc=baohua.song@csr.com \
--cc=jacmet@sunsite.dk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=wernerandy@gmx.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®