From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Peter Wu <lekensteyn@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] coredumps truncated after "new helper: dump_align()"
Date: Fri, 15 Nov 2013 12:57:59 -0800 [thread overview]
Message-ID: <1384549079.18739.33.camel@joe-AO722> (raw)
In-Reply-To: <20131115203838.GJ13318@ZenIV.linux.org.uk>
On Fri, 2013-11-15 at 20:38 +0000, Al Viro wrote:
> On Fri, Nov 15, 2013 at 03:26:10PM +0100, Peter Wu wrote:
> > Somewhere in the merge window of 3.13, coredumps appear truncated.
> > Instead of 319488 bytes, I get 868 bytes (tested with x86_64 only).
> >
> > The latest Linus' master (v3.12-9579-g049ffa8) is still affected.
> > Bisection leads to:
> >
> > commit 22a8cb8248ba5d340307ba72432253b1dbdb5cf7
trivia:
> diff --git a/fs/coredump.c b/fs/coredump.c
[]
> @@ -733,7 +733,7 @@ int dump_align(struct coredump_params *cprm, int align)
> {
> unsigned mod = cprm->written & (align - 1);
> if (align & (align - 1))
> - return -EINVAL;
> - return mod ? dump_skip(cprm, align - mod) : 0;
> + return 0;
> + return mod ? dump_skip(cprm, align - mod) : 1;
> }
> EXPORT_SYMBOL(dump_align);
extern int dump_skip(struct coredump_params *cprm, size_t nr);
extern int dump_emit(struct coredump_params *cprm, const void *addr, int nr);
extern int dump_align(struct coredump_params *cprm, int align);
Perhaps all of these should return bool not int.
Is there a reason these should be EXPORT_SYMBOL?
next prev parent reply other threads:[~2013-11-15 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 14:26 Peter Wu
2013-11-15 20:38 ` Al Viro
2013-11-15 20:57 ` Joe Perches [this message]
2013-11-15 21:34 ` Peter Wu
2013-11-16 0:04 ` Al Viro
2013-11-17 6:19 ` Al Viro
2013-11-17 9:59 ` Peter Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384549079.18739.33.camel@joe-AO722 \
--to=joe@perches.com \
--cc=lekensteyn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®