From: Andreas Werner <wernerandy@gmx.de>
To: wsa@the-dreams.de
Cc: khali@linux-fr.org, jacmet@sunsite.dk, hskinnemoen@gmail.com,
dianders@chromium.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, wernerandy@gmx.de
Subject: [PATCH v2] I2C: busses: i2c-eg20t Do not print error message in syslog if no ACK received
Date: Sun, 17 Nov 2013 09:58:51 +0100 [thread overview]
Message-ID: <1384678731-10399-1-git-send-email-wernerandy@gmx.de> (raw)
Revision 2:
- delete the pch_err completly instead of changing to pch_dbg
because there is already a pch_dbg at the function who calls
pch_i2c_getack.
- Fixed message line issue
Using the i2c-eg20t driver and call i2cdetect or probe on the bus,
the driver will print a lot of error messages if there was no ACK
received.
i2cdetect normally print a table with all the available devices. If there
is no device on the address, the table will be empty.
Currently with the i2c-eg20t driver, the table is not visible because
the error messages destroy the table.
Error message: pch_i2c_getack return -71
This patch prevent the driver to print the messages to syslog.
The pch_i2c_wait_for_check_xfer function is the only one who is
calling pch_i2c_getack, and there is already a dbg print if it fails,
so we can delete the pch_err in pch_i2c_getack completly.
Fixed print message to be a one liner so we can grep for the
error message.
Tested on Intel Atom E6xx and Eg20t Chipset.
Signed-off-by: Andreas Werner <wernerandy@gmx.de>
---
drivers/i2c/busses/i2c-eg20t.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 0f37529..5c39f90 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -321,10 +321,8 @@ static s32 pch_i2c_getack(struct i2c_algo_pch_data *adap)
void __iomem *p = adap->pch_base_address;
reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
- if (reg_val != 0) {
- pch_err(adap, "return%d\n", -EPROTO);
+ if (reg_val != 0)
return -EPROTO;
- }
return 0;
}
@@ -367,8 +365,7 @@ static int pch_i2c_wait_for_check_xfer(struct i2c_algo_pch_data *adap)
adap->pch_event_flag = 0;
if (pch_i2c_getack(adap)) {
- pch_dbg(adap, "Receive NACK for slave address"
- "setting\n");
+ pch_dbg(adap, "Receive NACK for slave address setting\n");
return -EIO;
}
--
1.8.4
next reply other threads:[~2013-11-17 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 8:58 Andreas Werner [this message]
2013-11-17 11:08 ` Wolfram Sang
2013-11-17 12:39 ` Andreas Werner
2013-11-17 12:18 ` Wolfram Sang
2013-11-17 16:53 ` Andreas Werner
2013-11-17 17:08 ` Wolfram Sang
2013-11-17 17:16 ` Andreas Werner
2013-11-17 17:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384678731-10399-1-git-send-email-wernerandy@gmx.de \
--to=wernerandy@gmx.de \
--cc=dianders@chromium.org \
--cc=hskinnemoen@gmail.com \
--cc=jacmet@sunsite.dk \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®