From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbeAZIWW (ORCPT ); Fri, 26 Jan 2018 03:22:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40858 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751355AbeAZIWU (ORCPT ); Fri, 26 Jan 2018 03:22:20 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 27CCE608CB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cpandya@codeaurora.org Subject: Re: [PATCH] of: use hash based search in of_find_node_by_phandle To: Frank Rowand , robh+dt@kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <1516875247-19599-1-git-send-email-cpandya@codeaurora.org> <5a7793df-725e-608d-778b-cb81fde0cc64@gmail.com> From: Chintan Pandya Message-ID: <13846fcb-3aa2-a4fb-1bd8-e624855f105d@codeaurora.org> Date: Fri, 26 Jan 2018 13:52:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <5a7793df-725e-608d-778b-cb81fde0cc64@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/26/2018 1:24 AM, Frank Rowand wrote: > On 01/25/18 02:14, Chintan Pandya wrote: >> of_find_node_by_phandle() takes a lot of time finding >> right node when your intended device is too right-side >> in the fdt. Reason is, we search each device serially >> from the fdt, starting from left-most to right-most. > Please give me a pointer to the code that is doing > this search. > > -Frank You can refer include/linux/of.h #define for_each_of_allnodes_from(from, dn) \         for (dn = __of_find_all_nodes(from); dn; dn = __of_find_all_nodes(dn)) #define for_each_of_allnodes(dn) for_each_of_allnodes_from(NULL, dn) where __of_find_all_nodes() does struct device_node *__of_find_all_nodes(struct device_node *prev) {         struct device_node *np;         if (!prev) {                 np = of_root;         } else if (prev->child) {                 np = prev->child;         } else {                 /* Walk back up looking for a sibling, or the end of the structure */                 np = prev;                 while (np->parent && !np->sibling)                         np = np->parent;                 np = np->sibling; /* Might be null at the end of the tree */         }         return np; } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project