From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
"open list:SERVER ENGINES 10..." <linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code
Date: Sun, 17 Nov 2013 11:42:51 -0800 [thread overview]
Message-ID: <1384717371.2050.2.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1384714284-13712-1-git-send-email-geyslan@gmail.com>
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote:
> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and
> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when
> necessary.
You pointlessly renamed a variable, which makes the diff hard to read.
Please don't do that.
You missed the fact that the passed in pointer is unmodified if
mgmt_get_if_info() returns non zero, so the kfree frees junk and would
oops.
There's no need for a goto; len = -EINVAL; does everything that's
needed.
James
next prev parent reply other threads:[~2013-11-17 19:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 18:51 Geyslan G. Bem
2013-11-17 19:42 ` James Bottomley [this message]
2013-11-17 21:09 ` Geyslan Gregório Bem
2013-11-17 21:38 ` James Bottomley
2013-11-18 1:12 ` Geyslan Gregório Bem
2013-11-18 14:58 ` James Bottomley
2013-11-18 16:18 ` Geyslan Gregório Bem
2013-11-18 16:24 ` James Bottomley
2013-11-18 16:42 ` Geyslan Gregório Bem
2013-11-18 19:51 ` Geyslan Gregório Bem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384717371.2050.2.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=geyslan@gmail.com \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®