From: Joe Perches <joe@perches.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Florian Meier <florian.meier@koalo.de>,
Stephen Warren <swarren@wwwdotorg.org>,
"Koul, Vinod" <vinod.koul@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
devicetree <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
dmaengine <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv7] dmaengine: Add support for BCM2835
Date: Mon, 18 Nov 2013 14:18:48 -0800 [thread overview]
Message-ID: <1384813128.17783.3.camel@joe-AO722> (raw)
In-Reply-To: <20131118145400.GE16735@n2100.arm.linux.org.uk>
On Mon, 2013-11-18 at 14:54 +0000, Russell King - ARM Linux wrote:
> On Mon, Nov 18, 2013 at 04:30:17PM +0200, Andy Shevchenko wrote:
> > On Mon, 2013-11-18 at 13:16 +0100, Florian Meier wrote:
> > > >> + uint32_t chans_available;
> > > >
> > > > Why uint32_t?
> > >
> > > Because it is a bit mask of fixed length that directly comes from the
> > > firmware.
> >
> > Like one already told you in your i2s patch, please, change that to
> > corresponding u* value, namely u32.
>
> There's no problem with uint32_t vs u32 - either will do. u32 is the
> pre-stdint.h Linux definition of a 32-bit unsigned integer. There's
> no reason why uint32_t isn't perfectly acceptable. It's a matter of
> author taste which gets used. (Except where modifications are to an
> existing chunk of code using one or the other - where consistency then
> matters more.)
https://lkml.org/lkml/2006/5/2/258
next prev parent reply other threads:[~2013-11-18 22:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 15:39 Florian Meier
2013-11-17 16:02 ` Joe Perches
2013-11-17 16:37 ` Florian Meier
2013-11-17 20:12 ` [PATCH] mmp_pdma: Style neatening Joe Perches
2013-11-28 9:34 ` Vinod Koul
2013-11-18 10:00 ` [PATCHv7] dmaengine: Add support for BCM2835 Shevchenko, Andriy
2013-11-18 12:16 ` Florian Meier
2013-11-18 14:30 ` Andy Shevchenko
2013-11-18 14:37 ` Florian Meier
2013-11-18 14:54 ` Russell King - ARM Linux
2013-11-18 15:04 ` Mark Rutland
2013-11-18 22:18 ` Joe Perches [this message]
2013-11-18 14:41 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384813128.17783.3.camel@joe-AO722 \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=florian.meier@koalo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®